Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'from' usage in pipeline conditions #1499

Closed
jkljf opened this issue Oct 30, 2019 · 1 comment
Closed

Support 'from' usage in pipeline conditions #1499

jkljf opened this issue Oct 30, 2019 · 1 comment

Comments

@jkljf
Copy link

jkljf commented Oct 30, 2019

Expected Behavior

On generating the pod for conditions, if 'from' is used for the condition's resource, the pod could mount to that resource (e.g. /pvc/) then copy to condition resource's workspace.
This is similar to Task usage in the pipeline.

Actual Behavior

No support 'from', any Git resource declared for the condition will be handled as normal Git fetch.

Steps to Reproduce the Problem

  1. Define a normal Condition check with resource type Git
  2. Use that Condition in the pipeline, expect 'from' can be used

Additional Info

@bobcatfish
Copy link
Collaborator

Thanks for opening this @jkljf ! I think this is a duplicate of #1256 so I'm going to close it, but I'm going to copy some of your description into there also :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants