-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kaniko build + push test to actually push #144
Comments
@aaron-prindle @bobcatfish I think this might not be an issue anymore, I think I was having issues because of the building of the image, but was hard to tell since we don't get back logs from build to know what happened. Check #120 |
Should this issue be closed? |
Yeah let's close it, I'll open another one to add a check to the integration test that the image was actually pushed. We should also make another one to use the |
|
Expected Behavior
Our integration test for the kaniko build and push functionality(#62, implemented in #120) should be able to actually push an image to a docker registry and verify that it was pushed by checking in the registry.
The kaniko integration test should also verify that this image has been pushed by looking at info about it in the registry.
Actual Behavior
Our integration test is running kaniko with
--no-push
because although boskos + the other test infra scripts setup auth such that we can interact with the boskos project (including the boskos GCR registry at$DOCKER_REPO_OVERRIDE
), this secret is not provided to the system under test, and after talking about this with @krzyzacy there doesn't seem to currently be a good/safe way to do this.Steps to Reproduce the Problem
--no-push
from the arguments to kaniko inkaniko_test_task.go
Additional Info
The best solution that came up when discussing with @krzyzacy was to create a new registry just for this, and whitelist the boskos system accounts.
The system accounts look like this
$PROJECT_NUMBER-compute@developer.gserviceaccount.com
. We can get the values for$PROJECT_NUMBER
that we need to white list from the knative boskos config.I'm not a huge fan of having to maintain test infrastructure that not all contributors will have access too but this is the best solution so far!
The text was updated successfully, but these errors were encountered: