From 8b11791ddc3d464a5fc0a586c94dae887528b184 Mon Sep 17 00:00:00 2001 From: Tejal Desai Date: Wed, 3 Oct 2018 11:54:19 -0700 Subject: [PATCH 1/2] Add dep version and emphasize on running ./hack/update-deps.sh Mention the dep version to install. The Gopkg.lock file format is changed in dep v0.5.0 on. Running `dep ensure` with previous creates a bunch of unwanted changes. --- DEVELOPMENT.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index f64029be19d..6965d95e928 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -44,7 +44,9 @@ You must install these tools: 1. [`go`](https://golang.org/doc/install): The language `Pipeline CRD` is built in 1. [`git`](https://help.github.com/articles/set-up-git/): For source control 1. [`dep`](https://github.com/golang/dep): For managing external Go - dependencies. + dependencies. + + Please Install dep v0.5.0 or greater. 1. [`ko`](https://github.com/google/go-containerregistry/tree/master/cmd/ko): For development. 1. [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/): For interacting with your kube cluster (also required for kubebuidler) @@ -91,7 +93,9 @@ While iterating on the project, you may need to: 1. [Run everything](#running-everything) 1. Verify it's working by [looking at the logs](#accessing-logs) -1. Update your (external) dependencies with: `./hack/update-deps.sh`. +1. Update your (external) dependencies with: `./hack/update-deps.sh`. + + __Running dep ensure manually, will pull a bunch of scripts deleted [here](./hack/update-deps.sh#L29)__ 1. Update your type definitions with: `./hack/update-codegen.sh`. 1. [Add new CRD types](#adding-new-types) 1. [Add and run tests](./test/README.md#tests) From c224a4f55b3d65bc65fd538e8e2342b58272a83e Mon Sep 17 00:00:00 2001 From: Tejal Desai Date: Wed, 3 Oct 2018 13:24:30 -0700 Subject: [PATCH 2/2] Remove the kube builder mentioned in the Tools --- DEVELOPMENT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 6965d95e928..49ec09df80f 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -49,7 +49,7 @@ You must install these tools: Please Install dep v0.5.0 or greater. 1. [`ko`](https://github.com/google/go-containerregistry/tree/master/cmd/ko): For development. -1. [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/): For interacting with your kube cluster (also required for kubebuidler) +1. [`kubectl`](https://kubernetes.io/docs/tasks/tools/install-kubectl/): For interacting with your kube cluster ## Environment Setup