From 30a4d8468202fbd3ab4db21dbbbbc3d7c651d185 Mon Sep 17 00:00:00 2001 From: Priti Desai Date: Wed, 5 Jul 2023 11:18:12 -0700 Subject: [PATCH] cleaning up config-artifact-* Config-artifact-pvc was introduce in https://github.com/tektoncd/pipeline/pull/866/files which was deleted in https://github.com/tektoncd/pipeline/pull/6150 These two resources are assumed to be used and needed by the storage pipeline resources which are gone now. These must be no longer needed and safe to clean up. Signed-off-by: Priti Desai --- config/200-role.yaml | 2 +- config/controller.yaml | 4 ---- pkg/apis/pipeline/storagetypes.go | 25 ------------------------- 3 files changed, 1 insertion(+), 30 deletions(-) delete mode 100644 pkg/apis/pipeline/storagetypes.go diff --git a/config/200-role.yaml b/config/200-role.yaml index 3f4e584fa4f..d0319ce98da 100644 --- a/config/200-role.yaml +++ b/config/200-role.yaml @@ -29,7 +29,7 @@ rules: - apiGroups: [""] resources: ["configmaps"] verbs: ["get"] - resourceNames: ["config-logging", "config-observability", "config-artifact-bucket", "config-artifact-pvc", "feature-flags", "config-leader-election", "config-registry-cert"] + resourceNames: ["config-logging", "config-observability", "feature-flags", "config-leader-election", "config-registry-cert"] --- kind: Role apiVersion: rbac.authorization.k8s.io/v1 diff --git a/config/controller.yaml b/config/controller.yaml index 63ff9425cf7..d4a18b134f3 100644 --- a/config/controller.yaml +++ b/config/controller.yaml @@ -98,10 +98,6 @@ spec: value: config-logging - name: CONFIG_OBSERVABILITY_NAME value: config-observability - - name: CONFIG_ARTIFACT_BUCKET_NAME - value: config-artifact-bucket - - name: CONFIG_ARTIFACT_PVC_NAME - value: config-artifact-pvc - name: CONFIG_FEATURE_FLAGS_NAME value: feature-flags - name: CONFIG_LEADERELECTION_NAME diff --git a/pkg/apis/pipeline/storagetypes.go b/pkg/apis/pipeline/storagetypes.go deleted file mode 100644 index edccac25bf9..00000000000 --- a/pkg/apis/pipeline/storagetypes.go +++ /dev/null @@ -1,25 +0,0 @@ -/* -Copyright 2019 The Tekton Authors - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -package pipeline - -const ( - // ArtifactStorageBucketType holds the name of the PipelineResource type for a bucket - ArtifactStorageBucketType = "bucket" - - // ArtifactStoragePVCType holds the name of the PipelineResource type for a pvc - ArtifactStoragePVCType = "pvc" -)