Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Pipelines v0.45 client breaks compatibility with older Pipeline servers #715

Closed
wlynch opened this issue Feb 21, 2023 · 0 comments · Fixed by tektoncd/pipeline#6206
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@wlynch
Copy link
Member

wlynch commented Feb 21, 2023

Pipelines v0.45 removed support for embedded statuses, not only as a feature flag but from the API altogether. This means that newer Pipeline clients can no longer guarantee compatibility with older Pipeline servers (e.g. LTS versions), since the flag only defaulted to minimal as of v0.44.0 (and prior to that, used full instead of both).

We noticed this incompatibility in our e2e tests when we updated client versions: #712

In response, we either need to:

  1. Drop support for Tekton Pipelines < v0.45 for new releases moving forward.
  2. Require usage of embedded-status: minimal flag for older server versions.
  3. See if we can rollback the change on the Pipelines side (we just need the field, not the controller functionality).
  4. Fork our own Pipelines types for compatibility 🤢
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant