fix ci

tekartik · Jul 20, 2024 · 41fcb74 · 41fcb74
1 parent b2c57db
commit 41fcb74
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -3,12 +3,12 @@
 version: 2
 
 enable-beta-ecosystems: true
+
 updates:
   - package-ecosystem: "pub"
     directory: "."
     schedule:
       interval: "monthly"
-
   - package-ecosystem: "github-actions"
     directory: "/"
     schedule:

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -5,7 +5,7 @@ homepage: https://github.com/tekartik/tekartik_html.dart
 publish_to: none
 
 environment:
-  sdk: '>=3.3.0 <4.0.0'
+  sdk: ^3.4.0
 dependencies:
   args:
   tekartik_common_utils:

diff --git a/test/raw_html_browser_test.dart b/test/raw_html_browser_test.dart
@@ -1,6 +1,8 @@
 @TestOn('browser')
 library html_browser_test;
 
+import 'dart:js_interop';
+
 import 'package:tekartik_common_utils/env_utils.dart';
 import 'package:test/test.dart';
 import 'package:web/web.dart';
@@ -58,23 +60,24 @@ void main() {
       element.attributes
           .setNamedItem(document.createAttribute('class')..value = 'test');
       // This fails on firefox: https://github.com/dart-lang/sdk/issues/23604
-      expect(element.outerHTML, '<div class="test"></div>');
+      expect(
+          (element.outerHTML as JSString).toDart, '<div class="test"></div>');
     });
 
     test('document', () {
       //new HtmlHtmlElement();
       final doc = document.implementation.createHTMLDocument('');
-      expect('<html><head><title></title></head><body></body></html>',
-          doc.documentElement!.outerHTML);
+      expect((doc.documentElement!.outerHTML as JSString).toDart,
+          '<html><head><title></title></head><body></body></html>');
       expect(doc.querySelector('head'), isNotNull);
       //doc.documentElement.nodes.insert(0, new HtmlDocument)
     });
     test('document title', () {
       //new HtmlHtmlElement();
       final doc = document.implementation.createHTMLDocument('title');
       expect(doc.title, 'title');
-      expect('<html><head><title>title</title></head><body></body></html>',
-          doc.documentElement!.outerHTML);
+      expect((doc.documentElement!.outerHTML as JSString).toDart,
+          '<html><head><title>title</title></head><body></body></html>');
       //doc.documentElement.nodes.insert(0, new HtmlDocument)
       expect(1, 1);
     });
@@ -83,7 +86,7 @@ void main() {
       // not working on firefox windows
       // ignore: unsafe_html
       final element = HTMLDivElement();
-      expect(element.outerHTML, '<div></div>');
+      expect((element.outerHTML as JSString).toDart, '<div></div>');
     });
   });
 }