Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version works in Waterfox, but newer ones do not. #8

Closed
PixelEater opened this issue Dec 21, 2017 · 3 comments
Closed

Old version works in Waterfox, but newer ones do not. #8

PixelEater opened this issue Dec 21, 2017 · 3 comments
Assignees
Labels
type/bug Bug report.

Comments

@PixelEater
Copy link

PixelEater commented Dec 21, 2017

I'm not sure if you would be able to do anything about this, but in the latest release of Waterfox (56.0.1 64-bit) this add-on seemingly does nothing. I found that actually version 1.0 successfully did change the default bookmarks folder, but I'm really after that add to top feature as well. Unfortunately Add Bookmark Here2 isn't working either. I wonder if you can see any way to restore the functionality since technically it did work at one point. I think true support for 56.* is a good goal at this time. I'm not positive if Waterfox could be basing something off the 54.* ESR and that could be causing it, but it does use the newer style bookmarks introduced in 56.

@teddy-gustiaux teddy-gustiaux self-assigned this Dec 23, 2017
@teddy-gustiaux teddy-gustiaux added the type/bug Bug report. label Dec 23, 2017
@teddy-gustiaux
Copy link
Owner

Thank you for reporting this issue! And for making me discover another fork of Firefox. 😃

I have indeed been able to verify that the built-in bookmarking features of the add-on do not work on the latest version of Waterfox, as well as with version 56.x of Firefox. The quick bookmarking features work fine. I have also found the origin of the problem: I have been using a property that is only available since the version 57 of Firefox. I am going to fix this right away and publish a fixed version of the add-on!

@teddy-gustiaux
Copy link
Owner

Version 2.1.2 has been published on AMO and should fix the problem. Let me know if you are still experiencing the issue after the update!

@PixelEater
Copy link
Author

That totally worked (after a restart). Thanks for the quick fix, and for bridging the gap where an old favorite no longer worked. Essential add-on, just one of those things where it's hard to imagine why this isn't default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug report.
Projects
None yet
Development

No branches or pull requests

2 participants