Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not all comment lines are recognized as comments #400

Closed
daslu opened this issue Mar 5, 2024 · 4 comments
Closed

not all comment lines are recognized as comments #400

daslu opened this issue Mar 5, 2024 · 4 comments

Comments

@daslu
Copy link

daslu commented Mar 5, 2024

This is probably related to the underlying parsing library.

Here is an example.
Looks like every second comment line is unrecognized as comment.

 $ clj -Sdeps '{:deps {techascent/tech.ml.dataset {:mvn/version "7.027"}}}'
Clojure 1.11.1

(require 'tech.v3.dataset)

(spit "/tmp/data.csv"
      "# header comment A
# header comment B
# header comment C
# header comment D
x,y
# body comment A
# body comment B
# body comment C
# body comment D
1,2
3,4
5,6")

(tech.v3.dataset/->dataset "/tmp/data.csv")
/tmp/data.csv [7 2]:

| # header comment B | column-1 |
|--------------------|----------|
| # header comment D |          |
|                  x |        y |
|   # body comment B |          |
|   # body comment D |          |
|                  1 |        2 |
|                  3 |        4 |
|                  5 |        6 |
@cnuernber
Copy link
Collaborator

That was fixed in charred a version ago - tech.io hasn't been updated.

@cnuernber
Copy link
Collaborator

Thanks - btw - for filing - it is definitely a real bug, just fixed in a sub library.

@daslu
Copy link
Author

daslu commented Mar 5, 2024

Thanks!

@daslu
Copy link
Author

daslu commented Mar 5, 2024

Indeed adding com.cnuernber/charred {:mvn/version "1.034"} does prevent the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants