JS: Incorrect renaming variables

[malcom]

Probably the new/rewritten JS variable renamer introduced in v2.9.27 have some bugs that can lead to unexpected behavior in minified code.

The issue is observable and reproducible on minified Hyphenopoly_Loader.js file, for example some mismatched names:

source: s.res.he.set(t,{w:e.fetch(s.paths.patterndir+n,{credentials:s.s.CORScredentials})}),g.set(n,t)};
2.9.26: a.res.he.set(b,{w:n.fetch(a.paths.patterndir+c,{credentials:a.s.CORScredentials})}),m.set(c,b)};
2.9.27: e.res.he.set(t,{w:e.fetch(e.paths.patterndir+n,{credentials:e.s.CORScredentials})}),h.set(n,t)};
        ^                 ^       ^ ...

[ShaneMcC]

I ran a git bisect on this - and fb5ce73 is the commit that introduced the broken behaviour - so it is indeed the new variable renamer.

[jmooring]

This appears to be a whitespace problem. If I reformat the OP's example in vscode, then minimize, vars are renamed correctly.

[tdewolff]

Thanks for the bug report, I will be looking into this!

EDIT: the shortest I can make this is (e,s)=>{e=>0,s(e)} which incorrectly becomes (t,e)=>{e=>0,e(e)}.

[tdewolff]

This has been fixed in tdewolff/parse@3a696f8, a new released will be out soon as I have some other outstanding work

[tdewolff]

This has been fixed and released in v.2.11.0!