Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with CSS Minify when using flex property #398

Closed
stoyan-g opened this issue Apr 9, 2021 · 6 comments
Closed

Issues with CSS Minify when using flex property #398

stoyan-g opened this issue Apr 9, 2021 · 6 comments

Comments

@stoyan-g
Copy link

stoyan-g commented Apr 9, 2021

Hey @tdewolff,

We have encountered an issue with the flex property when minified.

The following flex: 1 1 auto; turns to flex:auto when minified.
The flex: 3 1 auto; but this turns into flex:initial

I can provide the full CSS code if needed.

Btw, thank you very much for the fast resolution of my previously posted issue!

Kind regards,
Stoyan

@tdewolff
Copy link
Owner

Thanks for the issue! The flex:1 1 auto; should be minified to flex:auto, so that seems correct. I've fixed the issue of flex:3 1 auto; which should NOT be minified to flex:initial, thanks for that! Let me know if this now works for you!

@stoyan-g
Copy link
Author

Hey there t@dewolff,

thank you very much for the fast reply. Would it be possible to push those fixes as well as any other modification you have made to an official release, so we can update the binary on our servers? If it is not possible at the moment could you provide an ETA of when a new release is expected?

Kind regards,
Stoyan

@tdewolff
Copy link
Owner

Absolutely! Just published v2.9.16!

@stoyan-g
Copy link
Author

Awesome @tdewolff, thanks again for the fast response. We at SiteGround are using the binary on our servers, do you have any plans to release a new CLI version with this patch included, so we can update the binary everywhere?

Kind regards,
Stoyan

@tdewolff
Copy link
Owner

Yes, the release includes binaries (perhaps I uploaded them right after you took a look).

@stoyan-g
Copy link
Author

Oh, I've must've missed that. Thank you very much!

Kind Regards,
Stoyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants