Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Consider only one variant from the tchap design #395

Closed
giomfo opened this issue Aug 16, 2021 · 0 comments
Closed

[Theme] Consider only one variant from the tchap design #395

giomfo opened this issue Aug 16, 2021 · 0 comments
Labels
iOS to estimate the task should be estimated before being planned

Comments

@giomfo
Copy link
Contributor

giomfo commented Aug 16, 2021

We defined in Tchap-ios a Style protocol (see) to handle 2 styles (variants) related to the light theme.

After discussion with the DINUM, we decided to consider only one variant as the actual light theme.
This will ease the rebase against Element-ios.

The retained variant is the variant2 (white header)

The aim here is to remove the use of the Style protocol in the Tchap screens. We will replace this style with the existing ThemeService call (see ThemeService.shared.theme in Element-ios code) . Only the light mode will be supported for the moment, it will be configured with the current variant2 of Tchap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS to estimate the task should be estimated before being planned
Projects
None yet
Development

No branches or pull requests

1 participant