Single header contains #include <flux/..>

[matthew-8925]

Hi,

FYI - the single include contains #include <flux/core/detail/jtckdint.h> - which makes it no longer a single file header and won't work on godbolt, etc.

flux/single_include/flux.hpp

Line 968 in 9a02b77

#include <flux/core/detail/jtckdint.h>

Could be useful to add a precommit hook just grep'ing the single include file for #include "... or #include <flux/.., if this slips through often.

Thanks!

[tcbrindle]

Hi @matthew-8925, thanks for the bug report!

The problem is that the single header builder was only looking for files ending .hpp, so the new header ending .h got skipped. It should be fixed in #222.

Could be useful to add a precommit hook just grep'ing the single include file for #include "... or #include <flux/.., if this slips through often.

As far as I know this is the first time it's happened, and hopefully the last! I'd definitely consider a check if it happens again -- I guess the Github Actions job that builds the single header on commits to main would be the right place?

[matthew-8925]

Thanks for the quick fix!

I see - not much point adding a grep check, doesn't seem like this exact issue could occur again.
An extra GH Action that runs a quick smoke test with the single include could make sense, as it should catch any issue where the single include doesn't compile.