Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal.now missing tests for user-supplied time zones #1134

Closed
justingrant opened this issue Nov 5, 2020 · 2 comments
Closed

Temporal.now missing tests for user-supplied time zones #1134

justingrant opened this issue Nov 5, 2020 · 2 comments
Labels
non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE!
Milestone
Next

Comments

@justingrant
Copy link
Collaborator

While building #1130 I noticed that there are no tests for the user-supplied time zone variations of Temporal.now. All the existing tests (except for the ones I added for ZDT) only use the default system time zone.
@ptomato ptomato added the non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE! label Nov 6, 2020
@ptomato ptomato added this to the Stage 3 milestone Nov 6, 2020
@ptomato
Copy link
Collaborator

ptomato commented Jan 14, 2021

This is a polyfill or test262 thing and isn't a requirement for Stage 3.

@ptomato ptomato modified the milestones: Stage 3, Stage 4 Jan 14, 2021
@ptomato ptomato modified the milestones: Stage 4, Next Feb 18, 2021
@cjtenny cjtenny mentioned this issue Feb 27, 2021
Closed
44 tasks
@ptomato
Copy link
Collaborator

ptomato commented May 10, 2022

We now have test262 tests for user-provided time zones in Temporal.Now.

@ptomato ptomato closed this as completed May 10, 2022
@ptomato ptomato mentioned this issue Jan 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
non-prod-polyfill THIS POLYFILL IS NOT FOR PRODUCTION USE!
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@justingrant @ptomato