Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] round corners support plugin #4497

Closed
Luciennnnnnn opened this issue Jun 28, 2022 · 7 comments
Closed

[feat] round corners support plugin #4497

Luciennnnnnn opened this issue Jun 28, 2022 · 7 comments

Comments

@Luciennnnnnn
Copy link

Describe the problem

request a round corner plugin to simulate the natural behavior of app on macOS.

Describe the solution you'd like

a plugin like https://github.com/tauri-apps/window-shadows

Alternatives considered

No response

Additional context

No response

@JonasKruckenberg
Copy link
Member

JonasKruckenberg commented Jun 28, 2022

Couple questions:

  1. What would your usecase for this be exactly?
  2. Why not use css to round the corners of undecorated windows?

My guess is you're trying to hide the ugly default titlebar on macOS, but if that's the case you need to think about this problem differently. On macOS you shouldn't use decoration: false but rather make the titlebar transparent. Support for this (if you're not comfortable with implementing it yourself) is coming with this pr: #3965

@Luciennnnnnn
Copy link
Author

yeah. I want to customize titlebar to get a consistent visual experiment between Windows and macOS.

I have forgotten the details of why I need a plug-in, I have a discussion on #app-devs channel of discord with @FabianLars (and this channel now is closed, I can't search our past discussion) . The conclusion is that we need native round-corner support other than implementing it by CSS.
The reason may be that we need to set [tauri.macOSPrivateApi] to true to enable transparent window on macOS, and this prevent app be accepted by apple as I remembered. see #3481

@FabianLars
Copy link
Member

@JonasKruckenberg This is the convo: https://discord.com/channels/616186924390023171/622768087183130673/974651874441572363
Btw we need to make the archive public again (read-only ofc), there is much lost info rn.

And yes, you're essentially looking for #3965 like Jonas said (note that the transparency he mentions is not the private api stuff)

@Luciennnnnnn
Copy link
Author

@JonasKruckenberg This is the convo: https://discord.com/channels/616186924390023171/622768087183130673/974651874441572363 Btw we need to make the archive public again (read-only ofc), there is much lost info rn.

And yes, you're essentially looking for #3965 like Jonas said (note that the transparency he mentions is not the private api stuff)

Do you mean that we no longer need a rounded plug-in with #3965 ?

@FabianLars
Copy link
Member

Yes, same for the shadows plugin (on macOS)

@Luciennnnnnn
Copy link
Author

Yes, same for the shadows plugin (on macOS)

That's great. I'm looking forward to using this feature.

@JonasKruckenberg
Copy link
Member

I will close this issue then 👍

@JonasKruckenberg JonasKruckenberg closed this as not planned Won't fix, can't repro, duplicate, stale Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants