Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Tauri 2.1.1 & 1.8.1 is affected by glib-rs 0.15 security vulnerability #12048

Closed
ilyagr opened this issue Dec 25, 2024 · 6 comments
Closed
Labels
dependencies Pull requests that update a dependency file platform: Linux status: upstream This issue is blocked by upstream dependencies and we need to wait or contribute upstream fixes

Comments

@ilyagr
Copy link

ilyagr commented Dec 25, 2024

Describe the bug

The tauri 1.8.1 Rust package currently requires glib@0.15 on Linux, but versions of glib (the Rust bindings) >=0.15 and <0.20 are affected by GHSA-wrw7-89jp-8q8g . I believe (but am not sure) that the nightly version of Tauri 1 probably depends on glib@0.18, which is also bad.

GitHub informed me about this in https://github.com/ilyagr/diffedit3/security/dependabot/10.

Reproduction

No response

Expected behavior

It'd be great if there was a tauri 1.18.2 that could work with glib 0.20 :)

Full tauri info output

N/A

Stack trace

No response

Additional context

No response

@ilyagr ilyagr added status: needs triage This issue needs to triage, applied to new issues type: bug labels Dec 25, 2024
@ilyagr ilyagr changed the title [bug] Tauri 1.8.1 is affected by glib 0.15 security vulnerability [bug] Tauri 1.8.1 is affected by glib-rs 0.15 security vulnerability Dec 25, 2024
@FabianLars
Copy link
Member

Since the gtk3 bindings are unmaintained I think this is a wontfix sadly. (We don't use glib directly ourselves)

@FabianLars FabianLars added status: upstream This issue is blocked by upstream dependencies and we need to wait or contribute upstream fixes platform: Linux dependencies Pull requests that update a dependency file and removed type: bug status: needs triage This issue needs to triage, applied to new issues labels Dec 25, 2024
@ilyagr
Copy link
Author

ilyagr commented Dec 25, 2024

If the gtk3 bindings are never made compatible with glib 0.20, another option might be to downgrade to gtk 0.14.3. Unless, of course, another security bug appears that affects older versions of some gtk dependency...

@ilyagr
Copy link
Author

ilyagr commented Dec 27, 2024

Actually, Tauri 2.1.1 also seems affected. It seems to be using gtk v0.18.2 which seems to depend on glib v0.18. I'm surprised it's not showing up in the Security tab of this repo; I guess you didn't enable dependency-based security warning.

Cc: #7335

@ilyagr ilyagr changed the title [bug] Tauri 1.8.1 is affected by glib-rs 0.15 security vulnerability [bug] Tauri 2.1.1 & 1.8.1 is affected by glib-rs 0.15 security vulnerability Dec 27, 2024
@FabianLars
Copy link
Member

We do see them in the Security tab, but only those with repo access can see that (afaik github doesn't allow us to make this public?).
And I think there's no gh issue because this is still not resolved: rustsec/audit-check#8

I doubt anyone in the community would be interested in forking the gtk3 bindings so i'll close this in favor of #7335 (but only because this unsound issue doesn't seem to affect us)

@FabianLars FabianLars closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
@ilyagr
Copy link
Author

ilyagr commented Dec 28, 2024

Thanks for looking into this!

I didn't understand what you said about rustsec/audit-check#8 and how the check should be behaving, nor why this "wouldn't affect us", so I'd appreciate more details if you are feeling like explaining it. But you are the expert here, so I trust your conclusion that Tauri for Linux not on fire. Glad to hear it!

@FabianLars
Copy link
Member

I didn't understand what you said about rustsec/audit-check#8 and how the check should be behaving

We have an audit workflow that opens public issues like this one #11641 but it's not working for unsound issues due to a bug in the linked github action.

nor why this "wouldn't affect us"

This was about the unsound issue itself. We've been using the affected glib versions for 3? years (since the day 0.15 was released basically) without any issues. This is good enough in my eyes to not have us spend resources that we really do not have on forking&maintaining the gtk3 crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file platform: Linux status: upstream This issue is blocked by upstream dependencies and we need to wait or contribute upstream fixes
Projects
None yet
Development

No branches or pull requests

2 participants