Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnosis Safe bootstrap (PR#217) - Open threads #237

Open
marcelomorgado opened this issue Mar 1, 2019 · 0 comments
Open

Gnosis Safe bootstrap (PR#217) - Open threads #237

marcelomorgado opened this issue Mar 1, 2019 · 0 comments
Labels
enhancement New feature or request question Further information is requested tech debt Technical debt not involving bugs or features
Milestone

Comments

@marcelomorgado
Copy link
Contributor

marcelomorgado commented Mar 1, 2019

1. Create an assertion to check if the beneficiary received funds withdrawn from safe
Refs: #217 (comment)

2. Create tasit-sdk integration test using tasit-identity-contract (That will renamed to tasit-contract-based-account) and tasit-link-wallet for:
Spend funds from a contract based account by an ephemeral account (after linked)
Refs: #217 (comment)

3. Create a test case against GnosisSafe.multSign() function
Refs: #217 (comment)

4. Understand "gas-per-byte" calculation from GnosisSafeUtils.
Related to: https://github.com/OpenZeppelin/openzeppelin-solidity/blob/master/contracts/cryptography/ECDSA.sol
Refs: #217 (comment)

5. Discussion about global usage.
Refs: #217 (comment)

6. Discussion about ganache-cli snapshots inside of beforeEach hooks.
Refs: #217 (comment)

7. Discussion about tasit-account as dependency of tasit-identity-contract
Refs: #217 (comment), #217 (comment)

8. Discussion about minter wallet name
Refs: #217 (comment)

9. Comments
Refs: #217 (comment), #217 (comment), #217 (comment),
#217 (comment),
#217 (comment),
#217 (comment),
(PR #238)

10. Rename action.waitForNonceToUpdate() to action.waitForOneConfirmation() (PR #355)

11. Discussion about capitalization
Refs: #217 (comment)

@marcelomorgado marcelomorgado added enhancement New feature or request question Further information is requested tech debt Technical debt not involving bugs or features labels Mar 1, 2019
@marcelomorgado marcelomorgado added this to the 0.2.0 release milestone Mar 1, 2019
@marcelomorgado marcelomorgado mentioned this issue May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested tech debt Technical debt not involving bugs or features
Projects
None yet
Development

No branches or pull requests

1 participant