Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR review checklist #1169

Closed
harpolea opened this issue May 27, 2020 · 0 comments · Fixed by #1588
Closed

Add PR review checklist #1169

harpolea opened this issue May 27, 2020 · 0 comments · Fixed by #1588
Assignees

Comments

@harpolea
Copy link
Contributor

A PR review checklist should be added to assist when reviewing pull requests. This should take the form of

  • a concise checklist which is posted in the PR itself for the reviewer to tick off. This could be done e.g. by triggering a github action when a reviewer is assigned which comments the checklist in the PR
  • an expanded form of the checklist in the TARDIS documentation which explains the points in more detail.

The checklist is not intended to be exhaustive (as different PRs will require different checks), but should give the reviewer a starting point for things to consider and provides a minimum standard which all PRs should meet before they are accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants