From 69c40837befc6dba7329f301735fdad5368e47cf Mon Sep 17 00:00:00 2001 From: karandesai-96 Date: Wed, 6 Apr 2016 14:35:59 +0530 Subject: [PATCH] Refactor, parametrize test_montecarlo_line_scatter. --- tardis/montecarlo/tests/test_cmontecarlo.py | 25 +++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/tardis/montecarlo/tests/test_cmontecarlo.py b/tardis/montecarlo/tests/test_cmontecarlo.py index 77f61643dd8..68cff909d1e 100644 --- a/tardis/montecarlo/tests/test_cmontecarlo.py +++ b/tardis/montecarlo/tests/test_cmontecarlo.py @@ -221,8 +221,29 @@ def test_increment_j_blue_estimator(packet_params, j_blue_idx, expected, packet, assert_almost_equal(model.line_lists_j_blues[j_blue_idx], expected) -def test_montecarlo_line_scatter(): - assert cmontecarlo_tests.test_montecarlo_line_scatter() +@pytest.mark.parametrize( + ['packet_params', 'expected_params'], + # TODO: Add scientifically sound test cases. + [({'virtual_packet': 1, 'tau_event': 2.9e13, 'last_line': 0}, + {'tau_event': 2.9e13, 'next_line_id': 2}), + + ({'virtual_packet': 0, 'tau_event': 2.9e13, 'last_line': 0}, + {'tau_event': 2.9e13, 'next_line_id': 2}), + + ({'virtual_packet': 0, 'tau_event': 2.9e13, 'last_line': 0}, + {'tau_event': 2.9e13, 'next_line_id': 2}), + ] +) +def test_montecarlo_line_scatter(packet_params, expected_params, packet, model, mt_state): + packet.virtual_packet = packet_params['virtual_packet'] + packet.tau_event = packet_params['tau_event'] + packet.last_line = packet_params['last_line'] + + cmontecarlo_methods.montecarlo_line_scatter(byref(packet), byref(model), + c_double(1.e13), byref(mt_state)) + + assert_almost_equal(packet.tau_event, expected_params['tau_event']) + assert_almost_equal(packet.next_line_id, expected_params['next_line_id']) def test_move_packet_across_shell_boundary():