From 2cd9e1c5f6cd3b3b8b1442750cd4b0a7956cc98e Mon Sep 17 00:00:00 2001 From: Dom Heinzeller Date: Mon, 16 Aug 2021 07:57:19 -0600 Subject: [PATCH 1/2] Fix wrong variable intent for tice in sfc_drv_ruc --- physics/GFS_surface_composites.F90 | 2 -- physics/sfc_drv_ruc.F90 | 3 +-- physics/sfc_drv_ruc.meta | 2 +- 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/physics/GFS_surface_composites.F90 b/physics/GFS_surface_composites.F90 index a15327f8b..966393d03 100644 --- a/physics/GFS_surface_composites.F90 +++ b/physics/GFS_surface_composites.F90 @@ -741,10 +741,8 @@ subroutine GFS_surface_composites_post_run ( weasd(i) = weasd_ice(i) * cice(i) snowd(i) = snowd_ice(i) * cice(i) qss(i) = qss_ice(i) - !tsfc(i) = tsfc_ice(i) evap(i) = evap_ice(i) hflx(i) = hflx_ice(i) - !tisfc(i) = tisfc(i) ! over lake ice (and sea ice when uncoupled) tsfc(i) = tsfc_ice(i) ! over lake (and ocean when uncoupled) ! if (flag_cice(i)) then diff --git a/physics/sfc_drv_ruc.F90 b/physics/sfc_drv_ruc.F90 index 6bdead7f7..f313f2fba 100644 --- a/physics/sfc_drv_ruc.F90 +++ b/physics/sfc_drv_ruc.F90 @@ -432,8 +432,7 @@ subroutine lsm_ruc_run & ! inputs ! for ice & weasd_ice, snwdph_ice, tskin_ice, & & tsurf_ice, z0rl_ice, tsnow_ice, & - & sfcqc_ice, sfcqv_ice, fice - real (kind=kind_phys), dimension(:), intent(out) :: tice + & sfcqc_ice, sfcqv_ice, fice, tice ! --- in real (kind=kind_phys), dimension(:), intent(in) :: & diff --git a/physics/sfc_drv_ruc.meta b/physics/sfc_drv_ruc.meta index ad4ae00ff..bdb058343 100644 --- a/physics/sfc_drv_ruc.meta +++ b/physics/sfc_drv_ruc.meta @@ -1550,7 +1550,7 @@ dimensions = (horizontal_loop_extent) type = real kind = kind_phys - intent = out + intent = inout optional = F [tsurf_ice] standard_name = surface_skin_temperature_after_iteration_over_ice From 8bf04be8c3736de9e4435f3a820fa5c1f47862a8 Mon Sep 17 00:00:00 2001 From: Dom Heinzeller Date: Mon, 16 Aug 2021 08:11:47 -0600 Subject: [PATCH 2/2] Update standard name from surface_skin_temperature_over_land_interstitial_save to surface_skin_temperature_over_land_save in physics/sfc_noah_wrfv4_interstitial.meta --- physics/sfc_noah_wrfv4_interstitial.meta | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/physics/sfc_noah_wrfv4_interstitial.meta b/physics/sfc_noah_wrfv4_interstitial.meta index 96b017be6..bff028fdc 100644 --- a/physics/sfc_noah_wrfv4_interstitial.meta +++ b/physics/sfc_noah_wrfv4_interstitial.meta @@ -520,8 +520,8 @@ intent = inout optional = F [tsfc_save] - standard_name = surface_skin_temperature_over_land_interstitial_save - long_name = surface skin temperature over land before entering a physics scheme (temporary use as interstitial) + standard_name = surface_skin_temperature_over_land_save + long_name = surface skin temperature over land before entering a physics scheme units = K dimensions = (horizontal_loop_extent) type = real @@ -894,7 +894,7 @@ intent = in optional = F [tsfc_save] - standard_name = surface_skin_temperature_over_land_interstitial_save + standard_name = surface_skin_temperature_over_land_save long_name = surface skin temperature over land before entering a physics scheme (temporary use as interstitial) units = K dimensions = (horizontal_loop_extent)