Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on debug print format #29

Closed
kornelski opened this issue Nov 2, 2020 · 2 comments · Fixed by #30
Closed

Don't rely on debug print format #29

kornelski opened this issue Nov 2, 2020 · 2 comments · Fixed by #30
Labels
C-bug Category: related to a bug.

Comments

@kornelski
Copy link

This crate assumes that {:#?} prints valid rust source code. Rust makes no guarantees about Debug format, so this code could break in the future.
@taiki-e taiki-e added the C-bug Category: related to a bug. label Nov 2, 2020
@taiki-e
Copy link
Owner

taiki-e commented Nov 2, 2020

Thanks, you are right. Probably rustversion crate also has the same issue.

@taiki-e taiki-e mentioned this issue Nov 2, 2020
Merged
@bors bors bot closed this as completed in c955c2b Nov 2, 2020
@bors bors bot closed this as completed in #30 Nov 2, 2020
@taiki-e
Copy link
Owner

taiki-e commented Nov 2, 2020

Published 0.4.3 which fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not rely on debug print format taiki-e/const_fn
2 participants
@kornelski @taiki-e