Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use accessor for FileDirectory class in ZnFileSystemUtils in Zinc-FileSystem-Legacy #4

Open
dalehenrich opened this issue Jul 30, 2012 · 2 comments
Open

use accessor for FileDirectory class in ZnFileSystemUtils in Zinc-FileSystem-Legacy #4

dalehenrich opened this issue Jul 30, 2012 · 2 comments

Comments

@dalehenrich
Copy link
Contributor

In GemStone, we want to use the class ServerFileDirectory instead of FileDirectory, so it will be much cleaner to maintain compatibility if only one method needed to be different rather than every method that references the class directly ... I'll make the changes in my port and issue a pull request when I've made the changes...

Thanks,

Dale
dalehenrich referenced this issue in dalehenrich/zinc Jul 30, 2012
Isolate the FileDirectory and FileStream class references in a single
53a9e63 
method to make porting to platforms with different class names easier to
maintain....

Issue GsDevKit#4
dalehenrich referenced this issue in dalehenrich/zinc Jul 30, 2012
Merge branch 'issue_4_sven' into issue_24_gs: proposed solution to Is…
6330334 
…sue GsDevKit#4
@dalehenrich
Copy link
Contributor Author

Here's the commit where I have made the proposed changes ... if the diffs look fine, then I'll go ahead and start the process to issue a pull request (have to isolate the changes in a commit off the master branch)...

@dalehenrich
Copy link
Contributor Author

Here's the commit where I corrected some mistakes in the original ... I didn't use fileStreamClass in all of the right places ... found that with testing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dalehenrich