I propose to pin @sveltejs/adapter-auto and @sveltejs/kit version in create-kit-docs script

[stephane-klein]

Hi,

@mihar-22 What do you think about pin @sveltejs/adapter-auto and @sveltejs/kit version here to avoid some version errors like #48 ?

Best regards,
Stéphane

[mihar-22]

We'll just need to update KitDocs to match the latest SvelteKit. Things are changing quickly as they're working towards 1.0 and I'm a little busy to keep up. If anyone opens a PR that does that I'll happily pull it in @stephane-klein :)

[stephane-klein]

@mihar-22 thanks ! 👍

Question: do you think it's a bad idea to pin versions? I think that it would save kit-docs users (like me) a lot of trouble in case of SvelteKit breaking change.

[mihar-22]

No problem!

I think you can cause trouble by both pinning and not. I think we have to just look at the likelihood of breaking changes occurring. I don't really see anything else breaking KitDocs because we're working with the very core of SvelteKit (mainly routing and endpoints). The recent CLI and Vite config change was a good thing for the ecosystem and is an example of a core change that won't really happen often.

If we find that it's breaking often we can definitely pin it until 1.0 :)

[stephane-klein]

If we find that it's breaking often we can definitely pin it until 1.0 :)

@mihar-22 ok, I understand, we will maybe pin it the next time 🙂

[stephane-klein]

@mihar-22 There are another breaking change #52, I think that vite version must be pinned.