From f57bd9c6aa8c98ef1b610519e346eac3b1287bd9 Mon Sep 17 00:00:00 2001 From: Luke Edwards Date: Thu, 18 Nov 2021 10:26:30 -0800 Subject: [PATCH 1/5] fix(cloudflare): add "publishConfig.access" key --- packages/adapter-cloudflare/package.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/adapter-cloudflare/package.json b/packages/adapter-cloudflare/package.json index e58bca94b8c4..dbb6ecdf2ad2 100644 --- a/packages/adapter-cloudflare/package.json +++ b/packages/adapter-cloudflare/package.json @@ -31,5 +31,8 @@ }, "devDependencies": { "@sveltejs/kit": "workspace:*" - } + }, + "publishConfig": { + "access": "public" + } } From 349c876ab85bf28c0c1ebab95c3bd57c43b5cd45 Mon Sep 17 00:00:00 2001 From: Luke Edwards Date: Thu, 18 Nov 2021 10:26:52 -0800 Subject: [PATCH 2/5] chore(cloudflare): add Pages project settings info --- packages/adapter-cloudflare/README.md | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/adapter-cloudflare/README.md b/packages/adapter-cloudflare/README.md index 62f05ae35e8b..434790d63709 100644 --- a/packages/adapter-cloudflare/README.md +++ b/packages/adapter-cloudflare/README.md @@ -39,7 +39,7 @@ export default { }; ``` -## Options +### Options The adapter optionally accepts all [`esbuild.build`](https://esbuild.github.io/api/#build-api) configuration. @@ -57,6 +57,21 @@ format: 'esm', bundle: true, ``` +## Deployment + +Please follow the [Get Started Guide](https://developers.cloudflare.com/pages/get-started) for Cloudflare Pages to begin. + +When configuring your project settings, you must use the following settings: + +* **Framework preset** – None +* **Build command** – `npm run build` or `svelte-kit build` +* **Build output directory** – `.svelte-kit/cloudflare` +* **Environment variables** + * `NODE_VERSION`: `16` or `14` + +> **Important:** You need to add a `NODE_VERSION` environment variable to both the "production" and "preview" environments. You can add this during project setup or later in the Pages project settings. SvelteKit requires Node `14.13` or later, so you should use `14` or `16` as the `NODE_VERSION` value. + + ## Changelog [The Changelog for this package is available on From 7fd93c87ee0bb2dc75c601570989dfe55c5287fa Mon Sep 17 00:00:00 2001 From: Luke Edwards Date: Thu, 18 Nov 2021 10:33:56 -0800 Subject: [PATCH 3/5] changeset --- .changeset/itchy-beds-drop.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/itchy-beds-drop.md diff --git a/.changeset/itchy-beds-drop.md b/.changeset/itchy-beds-drop.md new file mode 100644 index 000000000000..01a0d6906b0e --- /dev/null +++ b/.changeset/itchy-beds-drop.md @@ -0,0 +1,6 @@ +--- +"@sveltejs/adapter-cloudflare": patch +--- + +- Allow `npm publish` to succeed via `publishConfig.access` config +- Add instructions to README for configuring a new/existing Pages project From b847f9aec27ab3ae477dfa06d6c2a82e4ac3d43d Mon Sep 17 00:00:00 2001 From: Luke Edwards Date: Thu, 18 Nov 2021 10:35:38 -0800 Subject: [PATCH 4/5] linter --- packages/adapter-cloudflare/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/adapter-cloudflare/package.json b/packages/adapter-cloudflare/package.json index dbb6ecdf2ad2..b00c68d90278 100644 --- a/packages/adapter-cloudflare/package.json +++ b/packages/adapter-cloudflare/package.json @@ -33,6 +33,6 @@ "@sveltejs/kit": "workspace:*" }, "publishConfig": { - "access": "public" - } + "access": "public" + } } From 7f930b49f3858481e10389b23d2851be33a7918f Mon Sep 17 00:00:00 2001 From: Luke Edwards Date: Thu, 18 Nov 2021 10:38:41 -0800 Subject: [PATCH 5/5] this is ridiculous --- packages/adapter-cloudflare/README.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/adapter-cloudflare/README.md b/packages/adapter-cloudflare/README.md index 434790d63709..19e627ed7b6f 100644 --- a/packages/adapter-cloudflare/README.md +++ b/packages/adapter-cloudflare/README.md @@ -63,15 +63,14 @@ Please follow the [Get Started Guide](https://developers.cloudflare.com/pages/ge When configuring your project settings, you must use the following settings: -* **Framework preset** – None -* **Build command** – `npm run build` or `svelte-kit build` -* **Build output directory** – `.svelte-kit/cloudflare` -* **Environment variables** - * `NODE_VERSION`: `16` or `14` +- **Framework preset** – None +- **Build command** – `npm run build` or `svelte-kit build` +- **Build output directory** – `.svelte-kit/cloudflare` +- **Environment variables** + - `NODE_VERSION`: `16` or `14` > **Important:** You need to add a `NODE_VERSION` environment variable to both the "production" and "preview" environments. You can add this during project setup or later in the Pages project settings. SvelteKit requires Node `14.13` or later, so you should use `14` or `16` as the `NODE_VERSION` value. - ## Changelog [The Changelog for this package is available on