Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to TypeScript 4.8 #6387

Closed
benmccann opened this issue Aug 29, 2022 · 1 comment · Fixed by #6428
Closed

Upgrade to TypeScript 4.8 #6387

benmccann opened this issue Aug 29, 2022 · 1 comment · Fixed by #6428

Comments

@benmccann
Copy link
Member

benmccann commented Aug 29, 2022

Describe the problem

We're currently on TypeScript 4.7. We should probably update to TypeScript 4.8 while we're making a bunch of breaking changes

Describe the proposed solution

Run pnpm -r update typescript

I tried and running pnpm check on the kit project is causing some issue with the generated types that I don't understand saying that await parent() is returning null. I'm only a TypeScript beginner, so am hoping someone more knowledgeable might have some more insight

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

@dummdidumm
Copy link
Member

dummdidumm commented Aug 29, 2022

The error is coming from a change in behavior on TypeScript's side, I opened microsoft/TypeScript#50519 to see if this intended or a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants