Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax pyjwt further #272

Closed
zevisert opened this issue Jan 6, 2023 · 3 comments
Closed

Relax pyjwt further #272

zevisert opened this issue Jan 6, 2023 · 3 comments
Assignees

Comments

@zevisert
Copy link

zevisert commented Jan 6, 2023

This commit 81b897b changed your requirements from "PyJWT==2.0.*" to "PyJWT>=2.0.0 ,<=2.3.0", but even still that's IMO overly restrictive. PyJWT follows semantic versioning, so it appears to me that this project would be best off using "PyJWT>=2.0.0 ,<3.0.0" as it's dependency range.

@zevisert
Copy link
Author

zevisert commented Jan 6, 2023

Just using github code search, it doesn't seem like pyjwt is directly imported anywhere. I get why this project would want to use pyjwt, but it seems like it's not using it.

Python projects don't need to require transitive dependencies, so pyjwt could perhaps even be removed

@KShivendu
Copy link
Contributor

Hi @zevisert, thanks for raising this issue. This is indeed a valid point. I'll do the changes right away :)

Regarding the 2nd comment, I think there's a misunderstanding because of package import name. Try searching for from jwt (search results)

@rishabhpoddar
Copy link
Contributor

This has been fixed in python SDK version >= 0.11.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants