Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a bug in agreement library causing non super app callbacks in IDA case #246

Merged
merged 5 commits into from
Feb 8, 2021

Conversation

hellwolf
Copy link
Contributor

@hellwolf hellwolf commented Feb 7, 2021

  1. due to dividends rights token are no longer part of the test suite, this
    regression was not detected.
  2. IDA full test suite should cover this

1. due to dividends rights token are no longer part of the test suite, this
regression was not detected.
2. IDA full test suite should cover this
@hellwolf hellwolf requested a review from ngmachado February 7, 2021 18:35
@github-actions
Copy link

github-actions bot commented Feb 7, 2021

📦 PR Packages

Install this PR:

yarn add @superfluid-finance/js-sdk@PR246 --registry https://npm.pkg.github.com/
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your ~/.npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@hellwolf hellwolf merged commit ec60bf6 into dev Feb 8, 2021
@hellwolf hellwolf deleted the bug_callback_to_non_superapp branch February 8, 2021 10:46
@hellwolf
Copy link
Contributor Author

hellwolf commented Feb 8, 2021

@ngmachado thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants