Improve web3 options handling and single loadContracts #245
Conversation
📦 PR PackagesInstall this PR: yarn add @superfluid-finance/js-sdk@PR245 --registry https://npm.pkg.github.com/
|
Click to learn how to use Github packages| if (from) { | ||
| console.log("Set default from address to", from); | ||
| } else { | ||
| const accounts = await web3.eth.getAccounts(); | ||
| from = accounts[0]; | ||
| console.log( | ||
| "Set default from address to the first account", | ||
| from |
There was a problem hiding this comment.
The reason I didn't want to do this, is b/c I thought maybe a test will want to change from after the contract is loaded. If thats not the case then this is ok
There was a problem hiding this comment.
each transaction can always use the non-default from address.
this was added because it seems otherwise the deployment scripts didn't work...
| }); | ||
| } catch (e) { | ||
| throw Error( | ||
| `could not load non-truffle environment contracts. ${e}` | ||
| ); | ||
| } | ||
| } else { | ||
| } else if (isTruffle) { |
There was a problem hiding this comment.
Why did you add back isTruffle?
There was a problem hiding this comment.
to have an explicit error thrown on unknown mode.
| this.isTruffle = isTruffle; | ||
| this.ethers = ethers; |
There was a problem hiding this comment.
no longer can deploy test environment with ethers?
| * | ||
| * Usage: npx truffle exec scripts/reset-deployment.js : {VERSION} | ||
| */ | ||
| module.exports = async function(callback, argv) { | ||
| try { | ||
| global.web3 = web3; |
There was a problem hiding this comment.
ah maybe this is why ethers test were failing
| const config = Superfluid.getConfig(chainId); | ||
| console.log("reset: ", reset); | ||
| console.log("chain ID: ", chainId); | ||
| eval(`(${detectTruffleAndConfigure.toString()})(options)`); |
No description provided.