Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVE007 rewardAmount in AgreementLiquidated and other minor fixes #218

Merged
merged 4 commits into from
Jan 26, 2021
Merged

PVE007 rewardAmount in AgreementLiquidated and other minor fixes #218

merged 4 commits into from
Jan 26, 2021

Conversation

hellwolf
Copy link
Contributor

No description provided.

@hellwolf hellwolf linked an issue Jan 26, 2021 that may be closed by this pull request
PVE007: Inaccurate rewardAmount in AgreementLiquidated Events #213
Closed
@github-actions
Copy link

📦 PR Packages

Install this PR:

yarn add @superfluid-finance/js-sdk@PR218 --registry https://npm.pkg.github.com/
:octocat: Click to learn how to use Github packages

To use the Github package registry, create a token with "read:packages" permission. See Creating a personal access token for help.

Next add these lines to your ~/.npmrc file, replacing TOKEN with your personal access token. See Installing a package from Github if you get stuck.

@superfluid-finance:registry=https://npm.pkg.github.com
//npm.pkg.github.com/:_authToken=TOKEN

@ngmachado ngmachado self-requested a review January 26, 2021 19:30
@ngmachado ngmachado merged commit 811c803 into dev Jan 26, 2021
@ngmachado ngmachado deleted the security_na_fixes_batch1 branch January 26, 2021 19:31
@hellwolf hellwolf added this to the v1.0 milestone Jan 28, 2021
hellwolf added a commit to hellwolf/superfluid-protocol-monorepo that referenced this pull request Jan 28, 2021
@hellwolf
PVE007 rewardAmount in AgreementLiquidated and other minor fixes (sup…
6d34d8b 
…erfluid-org#218)

* improved comments about app allowance

* use correct rewardAmount in AgreementLiquidated event

* test all events in CFA:

- FlowUpdated, AgreementLiquidated and Bailout for CFA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngmachado ngmachado ngmachado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ethereum-contracts@v1.0 - Out of RCs
Development

Successfully merging this pull request may close these issues.

PVE007: Inaccurate rewardAmount in AgreementLiquidated Events
2 participants
@hellwolf @ngmachado