Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACTS] Version 1.7.2 Release #1569

Merged
merged 6 commits into from
Aug 11, 2023
Merged

Conversation

0xdavinchee
Copy link
Contributor

No description provided.

@0xdavinchee 0xdavinchee requested review from hellwolf, kasparkallas and a team as code owners August 9, 2023 08:27
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.40% 🎉

Comparison is base (4da4722) 87.39% compared to head (ceb0525) 95.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1569      +/-   ##
==========================================
+ Coverage   87.39%   95.79%   +8.40%     
==========================================
  Files          91       41      -50     
  Lines        4481     2186    -2295     
  Branches      186        0     -186     
==========================================
- Hits         3916     2094    -1822     
+ Misses        519       92     -427     
+ Partials       46        0      -46     
Flag Coverage Δ
ethereum-contracts 95.79% <ø> (ø)
sdk-core ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf hellwolf marked this pull request as draft August 9, 2023 09:48
@hellwolf
Copy link
Contributor

hellwolf commented Aug 9, 2023

let's wait until two more PR to be merged

@hellwolf hellwolf marked this pull request as ready for review August 10, 2023 13:19
@hellwolf
Copy link
Contributor

@0xdavinchee double check again before releasing

@0xdavinchee 0xdavinchee merged commit 9ecb24a into dev Aug 11, 2023
@0xdavinchee 0xdavinchee deleted the ethereum-contracts-1.7.2 branch August 11, 2023 11:56
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1569
https://xkcd.com/1569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants