Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHEREUM-CONTRACTS] host should be immutable #1542

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Conversation

0xdavinchee
Copy link
Contributor

There is no reason the host contract shouldn't be immutable on the SuperAppBaseFlow contract.
Save some gas and also allow SuperApps to be clones/proxies.

@0xdavinchee 0xdavinchee requested a review from hellwolf as a code owner July 21, 2023 11:42
@github-actions
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +8.81 🎉

Comparison is base (fb7bed2) 87.53% compared to head (95fa7a5) 96.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1542      +/-   ##
==========================================
+ Coverage   87.53%   96.35%   +8.81%     
==========================================
  Files          91       41      -50     
  Lines        4389     2139    -2250     
  Branches      184        0     -184     
==========================================
- Hits         3842     2061    -1781     
+ Misses        503       78     -425     
+ Partials       44        0      -44     
Flag Coverage Δ
ethereum-contracts 96.35% <0.00%> (ø)
sdk-core ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...reum-contracts/contracts/apps/SuperAppBaseFlow.sol 0.00% <0.00%> (ø)

... and 50 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xdavinchee 0xdavinchee merged commit 85afdd0 into dev Jul 21, 2023
@0xdavinchee 0xdavinchee deleted the immutable-host branch July 21, 2023 13:00
@github-actions
Copy link

XKCD Comic Relif

Link: https://xkcd.com/1542
https://xkcd.com/1542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants