Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUBGRAPH] get contract addresses for config from metadata (instead of duplicating) #1538

Closed
d10r opened this issue Jul 20, 2023 · 1 comment · Fixed by #1692
Closed

[SUBGRAPH] get contract addresses for config from metadata (instead of duplicating) #1538

d10r opened this issue Jul 20, 2023 · 1 comment · Fixed by #1692
Assignees
@0xdavinchee
Labels
Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps

Comments

@d10r
Copy link
Collaborator

d10r commented Jul 20, 2023

The json files in packages/subgraph/config duplicate contract addresses.
With metata inlined, we should get rid of that duplication by either dynamically get addresses from metadata of using a build script for creating this files.
@d10r d10r added the Tag: TechDebt Technical debt that needs to be addressed label Jul 20, 2023
@d10r d10r mentioned this issue Jul 20, 2023
Merged
@hellwolf hellwolf added the Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps label Aug 23, 2023
@hellwolf
Copy link
Contributor

@0xdavinchee is picking it up.

@0xdavinchee 0xdavinchee linked a pull request Sep 22, 2023 that will close this issue
[SUBGRAPH | METADATA] tech debt refactor #1692
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdavinchee 0xdavinchee

Labels
Tag: TechDebt Technical debt that needs to be addressed Team: Protocol Protocol Core, Sentinel, Peripherals, Protocol Infrastructure Tools & DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SUBGRAPH | METADATA] tech debt refactor superfluid-org/protocol-monorepo
3 participants
@hellwolf @d10r @0xdavinchee