Configurable resolution

[tasuki]

First, thank you so much! This is amazing!

Second, are you interested in contributions? Are random pull requests welcome?

Third, I created a fork with configurable resolution. This enables the player to see as much as they should be allowed by the game engine. Here's a sample screenshot at 540x420 (vs the original 320x240):

This work is not finished by any means: the "REALLY WANNA QUIT ?" message does not appear, there's no support for split screen, and there are several minor glitches. If you're interested in merging into mainline, I'll iron it out. Especially split screen would really benefit from higher resolution. Otherwise I can't be bothered: it works well enough for my purposes.

[akx]

I don't see why not! So long as it's configurable and doesn't mess with things too much. WDYT @veikkos @akheron?

[akheron]

Sure! There are already bug fixes and new features compared to the original, so I think the game can evolve as long as the spirit of the original is kept intact :)

[tasuki]

@akx and @akheron thank you both for the quick and positive replies. I started with two PRs containing some really minor stuff. The work on the larger viewport will take time, of which I'm currently short. Hopefully I'll report back in a couple weeks!

[tasuki]

@akx, I've created pull requests #197 (small albeit clear improvement imo) and #196 (perhaps more controversial, but great QoL improvement for me when running through the screens...) to test the waters. Any chance you'd take a look? Unless these get at least a response, I won't bother with the configurable resolution (I've made good progress on it though - split screen now works and I added a cli param to set the resolution!)

[tasuki]

Ultimately, this has been a rather unsatisfying experience. To my surprise, you replied instantly to my first inquiry, getting my hopes up. And then you ghosted me. It's a pity, I think my contributions were ok...

[akx]

@tasuki Sorry for the unsatisfying experience. I reviewed those small PRs – thanks for them.

To my best knowledge, no one here has knowingly ghosted you – please remember that this is a hobby project, and at least my GitHub notifications and Gmail inbox are bursting at the seams, so occasionally there's a notification missed.

[tasuki]

Ok fair. I've finished about 90% work for the configurable resolution, but there's some bad breakage in various random places. Seeing as you started merging my stuff, I'll try to push the remaining 10% (or 90% – who knows 😄).