Selected (Active) Tab color

[SNike-1]

Many files are open. Their names are similar, and they don't fit in the tabs. It's hard to figure out which tab is open. I suggest to somehow highlight the active tab. That would be very good. Thanks!

[kjk]

That should already be the case in latest pre-release https://www.sumatrapdfreader.org/prerelease

[SNike-1]

That should already be the case in latest pre-release
I didn't notice.

How to turn active tab highlite on?

[kjk]

I guess I have to make the contrast bigger. The color for active tab is different but it looks it should be more different.

[SNike-1]

if the active tab is clearly distinguishable among others, it will be very convenient!

[kjk]

I've increased the contrast to this:

[SNike-1]

Yes, so good. Thanks!

[username116]

A suggestion on colors in dark mode: (sorry I'm intruding on a discussion when this isn't exactly the topic)

Make a slight difference between the background colors of the window and the document. This would allow the edges of the document to be seen.
Currently, when document colors are also inverted, these colors (and that of the toolbar) are the same.
Or make these colors customizable in the advanced options, like the light theme? (but it must be some work, it's easy to have ideas).

Screenshots with the current colors, and a screenshot of another program, LibreOffice, as an example:

Click to unfold

[GitHubRulesOK]

@username116
SumatraPDF has had an "experimental" background feature as long as I can remember so you chose what you want within reason

one to three colours based on GradientColors = #ff0000 #0000FF after FixedPageUI [

[kjk]

@username116 done in https://github.com/sumatrapdfreader/sumatrapdf/commits/master, will be in next pre-release build

[username116]

Thank you very much for your answers.

@GitHubRulesOK I hadn't tried this setting. I tried it, and indeed I can set the background color I want, even in dark mode. Thanks for the tip.

@kjk thanks, I look forward to the next pre-release.

Idea: indicate in the advanced settings help of the next version, for TextColor, BackgroundColor and MainWindowBackground settings, that these settings don't work with dark themes. And for MainWindowBackground, that GradientColors can be used instead for a setting with dark theme.
This could save time for people like me trying to adjust the dark theme colors.

[username116]

Here's the result and how it compares with the previous version.

I don't see any difference with the light theme on my screenshots (although the code 98b86d6 also changes the lightness with the light theme?).
I would have set -8 instead of +8 with the dark theme, to darken the background of the document a little, instead of lightening it. With the text which is already a little greyed out, it lacks contrast in my eyes. But I got what I wanted, the edges of the sheet are visible. Thanks for the change.

Click to unfold

Before, with the light theme:

After :

Before, with the dark theme:

After :

[kjk]

If you look at at GetDocumentColors() it treats the light theme in a special way so this code won't execute which is why the light theme didn't change.