Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dlss-wowza plugin: only notify w honeybadger for prod #46

Open
ndushay opened this issue Sep 6, 2016 · 2 comments
Open

dlss-wowza plugin: only notify w honeybadger for prod #46

ndushay opened this issue Sep 6, 2016 · 2 comments

Comments

@ndushay
Copy link
Contributor

ndushay commented Sep 6, 2016

currently, honeybadger is notified whenever certain errors are thrown in the plugin code; we really only want honeybadger notified for errors on the wowza prod box, not wowza stage or dev.

@jmartin-sul
Copy link
Member

jmartin-sul commented Sep 12, 2016

discussed with @eefahy on thursday, and the plan is:

  • puppet will set an environment variable on the VM, indicating the deployment environment (e.g.: production, development, etc)
  • the plugin will read that env var and pass that value to set the honeybadger environment to for a given plugin deployment (similar to the way the plugin obtains the honeybadger api key).
  • the plugin code will not differentiate based on environment when deciding what to report to honeybadger. instead, notifications will be configured by environment in the honeybadger app settings, and notifications will be configured to only go out for prod errors.

PR #47 implemented the necessary wowza plugin code. we'll also need a puppet PR to set up the env var on the deployment VMs (there is currently a pending puppet PR for setting env vars on deployment machines).

as with the API key, a developer will need to set this env var on their laptop for the tests to run successfully. the var is called WOWZA_HONEYBADGER_ENV (the readme has been updated accordingly).

@jmartin-sul
Copy link
Member

we think this has been implemented as far as java code goes. there's been a minor deployment snag with the plugin being unable to read the environment variables it needs. we could either leave this open until we're sure that there won't be more related plugin code changes, or we could close it under the assumption that a wowza config fix (possibly via puppet) will resolve the issue (which, at the moment, is what i'm betting will happen).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants