From 50c1dab846f8d2a6d5bdd6b4db615990959ebf4d Mon Sep 17 00:00:00 2001 From: Tom Pantelis Date: Thu, 6 Feb 2025 08:09:51 -0500 Subject: [PATCH] Remove AddToScheme call in event controller New The global scheme is already set up by the callers and calling AddToScheme here can cause intermittent data race failures in unit tests. Signed-off-by: Tom Pantelis --- pkg/event/controller/controller.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pkg/event/controller/controller.go b/pkg/event/controller/controller.go index 19e502693..17bed0089 100644 --- a/pkg/event/controller/controller.go +++ b/pkg/event/controller/controller.go @@ -36,7 +36,6 @@ import ( v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/dynamic" - "k8s.io/client-go/kubernetes/scheme" "k8s.io/client-go/tools/cache" logf "sigs.k8s.io/controller-runtime/pkg/log" ) @@ -119,11 +118,6 @@ func New(config *Config) (*Controller, error) { return nil, errors.Wrap(err, "error processing env vars") } - err = subv1.AddToScheme(scheme.Scheme) - if err != nil { - return nil, errors.Wrap(err, "error adding submariner types to the scheme") - } - syncerConfig := &syncer.ResourceSyncerConfig{ SourceNamespace: env.Namespace, SourceClient: config.Client,