Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Hub controller for lighthouse #83

Closed
14 tasks
donaldh opened this issue Mar 18, 2022 · 6 comments
Closed
14 tasks

Epic: Hub controller for lighthouse #83

donaldh opened this issue Mar 18, 2022 · 6 comments
Assignees
Labels
axon For issues and PRs related to Axon. size:large

Comments

@donaldh
Copy link

donaldh commented Mar 18, 2022

Epic Description

The goal of this epic is to implement ServiceImport merging.

Once an mcs-controller has been introduced, the reconciliation logic will be extended to address
the following open issues:

  • Mark conflicting ServiceExport objects with the ServiceExportConflict condition
  • Merge matching ServiceExport objects into a single ServiceImport object

Related enhancement proposal: #111

Acceptance Criteria

Lighthouse behaviour aligns with MCS specification:

  • Mark conflicting ServiceExport objects with the ServiceExportConflict condition
  • Merge matching ServiceExport objects into a single ServiceImport object

Definition of Done (Checklist)

  • Code complete
  • Relevant metrics added
  • The acceptance criteria met
  • Unit/e2e test added & pass
  • CI jobs pass
  • Deployed using cloud-prepare+subctl
  • Deployed using ACM/OCM addon
  • Deploy using Helm
  • Deployed on supported platforms (for e.g kind, OCP on AWS, OCP on GCP)
  • Run subctl verify, diagnose and gather
  • Uninstall
  • Troubleshooting (gather/diagnose) added
  • Documentation added
  • Release notes added

Work Items

@donaldh donaldh added axon For issues and PRs related to Axon. next-version-candidate labels Mar 18, 2022
@vthapar
Copy link
Contributor

vthapar commented Mar 21, 2022

@donaldh Any specific reason why we need a hub controller and cant make this work without needing a centralized mcscontroller? Having a serverless broker has been one of the core design tenent of submariner. If we want to introduce a central controller to run on broker, it should be with a good enough reason. Note that an mcs controller with come withs own overhead of HA etc.

@donaldh
Copy link
Author

donaldh commented Mar 21, 2022

@vthapar I have described the reason in enhancement pr #82

@donaldh donaldh changed the title Hub controller for lighthouse Epic: Hub controller for lighthouse Mar 22, 2022
@dfarrell07
Copy link
Member

It seems like #82 is closed, and this Epic doesn't track #111. Should it be updated?

@donaldh
Copy link
Author

donaldh commented Apr 26, 2022

Good catch @dfarrell07, I have updated the title and description to match the ER.

@maayanf24
Copy link
Contributor

Talked on the planning call - Not a priority for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
axon For issues and PRs related to Axon. size:large
Projects
None yet
Development

No branches or pull requests

5 participants