Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inlet profile from file is not initialized from config.cfg #1265

Closed
bigfooted opened this issue Apr 17, 2021 · 4 comments
Closed

inlet profile from file is not initialized from config.cfg #1265

bigfooted opened this issue Apr 17, 2021 · 4 comments

Comments

@bigfooted
Copy link
Contributor

When SU2 creates an inlet profile file, the values in the file are set to 0.0, expect for the vertex coordinates. The values used to be initialized from MARKER_INLET in the config file. Any particular reason this initialization disappeared? I propose to add this again, and also to add a line to inlet.dat with the names of the variables in the columns so it's easier for users to see what's in the columns.

@bigfooted
Copy link
Contributor Author

implementation result:

NMARK= 2
MARKER_TAG= inlet_air
NROW=32
NCOL=8
# COORD-X               COORD-Y                 TEMPERATURE             VELOCITY                NORMAL-X                NORMAL-Y                TKE                     DISSIPATION
-2.500000000000000e-01  5.000000000000000e-02   3.000000000000000e+02   5.000000000000000e+00   1.000000000000000e+00   0.000000000000000e+00   1.500000000000000e-02   1.000000000000000e+02
-2.500000000000000e-01  4.838709677419802e-02   3.000000000000000e+02   5.000000000000000e+00   1.000000000000000e+00   0.000000000000000e+00   1.500000000000000e-02   1.000000000000000e+02


@pcarruscag
Copy link
Member

Sounds good so long as backwards compatibility is kept and the names for the columns and default values are passed into CMarkerProfileReaderFVM in a way that does not require it to do anything problem-specific.

@bigfooted
Copy link
Contributor Author

yes, it works with and without the additional column information.

@bigfooted
Copy link
Contributor Author

closed by #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants