From 5210e8d9e5bea110aff0fa1cc6109d3ee60277ae Mon Sep 17 00:00:00 2001 From: Stu Hood Date: Mon, 13 Mar 2023 12:55:28 -0700 Subject: [PATCH] Disable hardlinking of immutable inputs (#18487) As determined in #18162, hardlinking unfortunately does not play well with any of the implementations of Docker for macOS's filesystem virtualization. This change re-disables hardlinking of immutable inputs until #18162 and/or #18153 (which currently plans to switch to using symlinks for large files) are resolved. --- src/rust/engine/fs/store/src/lib.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/rust/engine/fs/store/src/lib.rs b/src/rust/engine/fs/store/src/lib.rs index cc7f29e3118..869087ed8bf 100644 --- a/src/rust/engine/fs/store/src/lib.rs +++ b/src/rust/engine/fs/store/src/lib.rs @@ -77,7 +77,9 @@ const GIGABYTES: usize = 1024 * MEGABYTES; // NB: These numbers were chosen after micro-benchmarking the code on one machine at the time of // writing. They were chosen using a rough equation from the microbenchmarks that are optimized // for somewhere between 2 and 3 uses of the corresponding entry to "break even". -const IMMUTABLE_FILE_SIZE_LIMIT: usize = 512 * KILOBYTES; +// TODO: Temporarily disabled until #18162 and/or #18153 are resolved, since hardlinks do not play +// well with Docker on macOS. +const IMMUTABLE_FILE_SIZE_LIMIT: usize = usize::MAX - 1; mod local; #[cfg(test)]