From a1cf1170b080ae33ebeed45231c5cf44a4aea96a Mon Sep 17 00:00:00 2001 From: Yuki Date: Fri, 7 Feb 2025 11:42:20 -0800 Subject: [PATCH] pr feedback --- .../RightAccessoryButton.swift | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Vertical Main Screen/RightAccessoryButton.swift b/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Vertical Main Screen/RightAccessoryButton.swift index 4cbc9c43495..404f6af103a 100644 --- a/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Vertical Main Screen/RightAccessoryButton.swift +++ b/StripePaymentSheet/StripePaymentSheet/Source/PaymentSheet/Vertical Main Screen/RightAccessoryButton.swift @@ -42,6 +42,16 @@ extension RowButton { return Image.icon_chevron_right.makeImage(template: true).withAlignmentRectInsets(UIEdgeInsets(top: -2, left: 0, bottom: 0, right: 0)) } } + + var directionalLayoutMargins: NSDirectionalEdgeInsets { + switch self { + case .change, .viewMore: + // Hacky - I happen to know that these are only used by the flatWithRadio style and require extra padding + return .insets(top: 8) + default: + return .zero + } + } } private var label: UILabel { @@ -88,11 +98,7 @@ extension RowButton { self.appearance = appearance self.didTap = didTap super.init(frame: .zero) - if accessoryType == .change || accessoryType == .viewMore { - directionalLayoutMargins = .insets(top: 8) - } else { - directionalLayoutMargins = .zero - } + directionalLayoutMargins = accessoryType.directionalLayoutMargins addAndPinSubview(stackView, directionalLayoutMargins: directionalLayoutMargins) accessibilityLabel = accessoryType.text