Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make onActivityResult() of the Fragment easy usable #1299

Closed
pvarry opened this issue Aug 5, 2019 · 2 comments
Closed

Make onActivityResult() of the Fragment easy usable #1299

pvarry opened this issue Aug 5, 2019 · 2 comments
Assignees
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@pvarry
Copy link

pvarry commented Aug 5, 2019

Summary

Every time the SDK need a onActivityResult(), for example on the authenticateSetup() an Activity instance is needed and the startActivityForResult() will be called for this Activity but if we need this callback inside a Fragment to change the view according to the result, we are basically struck, and need to implement boilerplate code.

Instead of that, can you also implement the startActivityForResult() of the Fragment: https://developer.android.com/reference/android/support/v4/app/Fragment.html#startActivityForResult(android.content.Intent,%20int) ?
Thank you

SDK version

Latest (com.stripe:stripe-android:10.1.1)

@mshafrir-stripe
Copy link
Collaborator

@pvarry I merged #1289 late last week, which adds support for exactly what you're asking for. It'll be part of the next release, which will go out today or tomorrow.

@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Aug 5, 2019
@mshafrir-stripe mshafrir-stripe self-assigned this Aug 5, 2019
@mshafrir-stripe
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

2 participants