Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android:supportsRtl="true" from stripe-3ds2-android library #1140

Closed
ChristianKatzmann opened this issue Jun 25, 2019 · 2 comments
Closed
Assignees
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@ChristianKatzmann
Copy link
Contributor

Summary

I specify android:supportsRtl="false" for my Android application in the app's AndroidManifest.xml. Unfortunately, the stripe-3ds2-android also sets this field with a value of true. This leads to an error in the Manifest Merger:

/Users/becker/Projects/android_app/app/src/main/AndroidManifest.xml:37:9-36 Error:
        Attribute application@supportsRtl value=(false) from AndroidManifest.xml:37:9-36
        is also present at [com.stripe:stripe-3ds2-android:0.0.17] AndroidManifest.xml:11:18-44 value=(true).
        Suggestion: add 'tools:replace="android:supportsRtl"' to <application> element at AndroidManifest.xml:32:5-208:19 to override.

While this might be true for your library, it might for sure not be true for any app that depends on your library. Please remove this statement from your application node of your AndroidManifest.xml so that we do not have to workaround this by using a tools:replace="android:supportsRtl" hack.

Code to reproduce

Set android:supportsRtl="false" explicitly on your application node in the AndroidManifest.xml and include the stripe-android (or directly on the stripe-3ds2-android) library

Android version

As this is an error in the library itself / in its AndroidManifest.xml, this affects any Android version.

Impacted devices

See above.

Installation method

Gradle

SDK version

9.3.5

Other information

N/A

@mshafrir-stripe mshafrir-stripe self-assigned this Jun 25, 2019
@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Jun 25, 2019
@mshafrir-stripe
Copy link
Collaborator

@ChristianBecker thanks for filing. This will be fixed in the next release.

@mshafrir-stripe
Copy link
Collaborator

@ChristianBecker this should be fixed in stripe-android 9.3.6, which was just published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

No branches or pull requests

2 participants