Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display snapshot origin field #1045

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented Dec 12, 2023

@mulkieran mulkieran self-assigned this Dec 12, 2023
@mulkieran mulkieran force-pushed the issue_project_643 branch 2 times, most recently from 2a024bb to 3438b44 Compare January 11, 2024 17:27
@mulkieran mulkieran force-pushed the issue_project_643 branch 3 times, most recently from f3ecc83 to 9b32adf Compare January 23, 2024 17:49
@mulkieran mulkieran changed the title Issue project 643 Display snapshot origin field Feb 5, 2024
@mulkieran
Copy link
Member Author

rebased.

@mulkieran mulkieran requested a review from bmr-cymru February 5, 2024 14:38
Copy link
Member

@bmr-cymru bmr-cymru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the changes from stratisd#3516 and all behaving as expected.

@mulkieran
Copy link
Member Author

This can go in any time after stratis-storage/stratisd#3516 .

@mulkieran mulkieran marked this pull request as ready for review February 26, 2024 15:06
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Member Author

If it passes, it's good.

@mulkieran
Copy link
Member Author

/packit build

@mulkieran
Copy link
Member Author

It looks like Packit is delayed...merging.

@mulkieran mulkieran merged commit 3380def into stratis-storage:master Feb 26, 2024
10 checks passed
@mulkieran mulkieran deleted the issue_project_643 branch February 26, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants