Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: combineTags not available in @storybook/csf@0.1.2 #487

Closed
justinmwarner opened this issue Jun 25, 2024 · 1 comment · Fixed by #491
Closed

[Bug]: combineTags not available in @storybook/csf@0.1.2 #487

justinmwarner opened this issue Jun 25, 2024 · 1 comment · Fixed by #491
Labels
bug Something isn't working needs triage

Comments

@justinmwarner
Copy link

Describe the bug

This commit: 1939323

Introduced combineTags, which isn't available in version 0.1.2 of @storybook/csf. I think we'll need to upgrade to 0.1.9 - ComponentDriven/csf@632d12b

To Reproduce

I reproduced this by having version 8.1.10 of the storybook suite with test-runner. You'll see the call stack complains on this line of test-runner:
acc[key].tags = (0, import_csf.combineTags)("test", "dev", ...previewAnnotations.tags, ...csf.meta?.tags || [], ...csf._stories[key].tags || []);

Saying that import_csf.combineTags is undefined.

System

Storybook Environment Info:

  System:
    OS: Windows 11 10.0.22631
    CPU: (20) x64 13th Gen Intel(R) Core(TM) i9-13900H
  Binaries:
    Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.4 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.1 - ~\AppData\Roaming\npm\pnpm.CMD <----- active
  Browsers:
    Edge: Chromium (126.0.2592.68)
  npmPackages:
    @storybook/addon-a11y: ^8.1.10 => 8.1.10
    @storybook/addon-actions: ^8.1.10 => 8.1.10
    @storybook/addon-controls: ^8.1.10 => 8.1.10
    @storybook/addon-coverage: ^1.0.4 => 1.0.4
    @storybook/addon-designs: ^8.0.2 => 8.0.2
    @storybook/addon-essentials: ^8.1.10 => 8.1.10
    @storybook/addon-interactions: ^8.1.10 => 8.1.10
    @storybook/addon-links: ^8.1.10 => 8.1.10
    @storybook/addon-webpack5-compiler-babel: 3.0.3 => 3.0.3
    @storybook/blocks: ^8.1.10 => 8.1.10
    @storybook/manager-api: ^8.1.10 => 8.1.10
    @storybook/react: ^8.1.10 => 8.1.10
    @storybook/react-webpack5: ^8.1.10 => 8.1.10
    @storybook/test: ^8.1.10 => 8.1.10
    @storybook/test-runner: ^0.19.0 => 0.19.0
    @storybook/types: ^8.1.10 => 8.1.10
    eslint-plugin-storybook: ^0.8.0 => 0.8.0
    msw-storybook-addon: 2.0.2 => 2.0.2
    storybook: ^8.1.10 => 8.1.10


^ This is after having the `peerDependencies` fix mentioned in additional context

Additional context

Adding this fixes it, but isn't ideal:


  "peerDependencies": {
    "@storybook/csf": "0.1.9"
  },

Thanks so much for the work here, it's been invaluable in our org.

@justinmwarner justinmwarner added bug Something isn't working needs triage labels Jun 25, 2024
@psychobolt
Copy link

I have same issue, csf needs to be upgraded. Adding this to my package.json for my yarn setup is a temporary workaround:

  "resolutions": {
    "@storybook/test-runner@0.19.0/@storybook/csf@npm:^0.1.2": "npm:0.1.9"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants