From cc421d44ccdc6f542605d880ccc060f1d0dede9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABtan=20Maisse?= Date: Wed, 19 Feb 2020 08:55:23 +0100 Subject: [PATCH 1/2] fix(centered): remove `typesVersions` attribute because this addon exports hand written types from base dir MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hand written types are inside addon base dir and so we can not use `typesVersions` ⚠️ Be careful when writing types by hand, they should be compatible with TS3.5 --- addons/centered/package.json | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/addons/centered/package.json b/addons/centered/package.json index 7ff0c37b0d87..77ed5f175323 100644 --- a/addons/centered/package.json +++ b/addons/centered/package.json @@ -46,12 +46,5 @@ "react-dom": "*", "regenerator-runtime": "*" }, - "gitHead": "4b9d901add9452525135caae98ae5f78dd8da9ff", - "typesVersions": { - "<=3.5": { - "*": [ - "ts3.5/*" - ] - } - } + "gitHead": "4b9d901add9452525135caae98ae5f78dd8da9ff" } From 5acd6cb3fc969e0a8a8cc732e4bdc125e0a78d10 Mon Sep 17 00:00:00 2001 From: Lynn Chyi <14299381+lychyi@users.noreply.github.com> Date: Wed, 19 Feb 2020 01:07:18 -0800 Subject: [PATCH 2/2] add dir cleanup and gitignore ts3.5 --- .gitignore | 1 + scripts/reset.js | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 1594748ce78d..4be2ff64a9d4 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,7 @@ node_modules *.sw* npm-shrinkwrap.json dist +ts3.5 .tern-port *.DS_Store .cache diff --git a/scripts/reset.js b/scripts/reset.js index c4b4c1d18cfb..7471d84082e9 100644 --- a/scripts/reset.js +++ b/scripts/reset.js @@ -28,6 +28,7 @@ cleaningProcess.stdout.on('data', data => { if ( uri.match(/node_modules/) || uri.match(/dist/) || + uri.match(/ts3\.5/) || uri.match(/\.cache/) || uri.match(/dll/) ) {