Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 5.0 deprecations for 6.0 #9521

Closed
2 tasks
shilman opened this issue Jan 18, 2020 · 2 comments
Closed
2 tasks

Remove 5.0 deprecations for 6.0 #9521

shilman opened this issue Jan 18, 2020 · 2 comments
Labels
BREAKING CHANGE maintenance User-facing maintenance tasks
Milestone
6.0 breaking

Comments

@shilman
Copy link
Member

shilman commented Jan 18, 2020 •
edited
Loading

Why

Storybook has a policy of deprecating APIs with util-deprecate to give users advanced notice of their removal. Now in 6.0 we should remove most of those deprecations and clean up the code.

What

Scour the code for util-deprecate:

  • If we think a deprecation is "too recent" or removing it will be too disruptive to users, add to a list of "remaining deprecations" in the PR description for review. Otherwise, remove/change API & clean code.
  • Update docs & MIGRATION.md for each change
@shilman shilman added maintenance User-facing maintenance tasks BREAKING CHANGE labels Jan 18, 2020
@shilman shilman added this to the 6.0.0 milestone Jan 18, 2020
@stale
Copy link

stale bot commented Feb 8, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 8, 2020
@shilman shilman added the todo label Feb 8, 2020
@stale stale bot removed the inactive label Feb 8, 2020
@shilman shilman modified the milestones: 6.0.0, 6.0 breaking changes Mar 10, 2020
@shilman
Copy link
Member Author

shilman commented Apr 14, 2020

Fixed in #10216

@shilman shilman closed this as completed Apr 14, 2020
@dependencies dependencies bot mentioned this issue Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BREAKING CHANGE maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.0 breaking
Development

No branches or pull requests
1 participant
@shilman