Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-load addons #764

Closed
ndelangen opened this issue Apr 12, 2017 · 5 comments
Closed

Auto-load addons #764

ndelangen opened this issue Apr 12, 2017 · 5 comments

Comments

@ndelangen
Copy link
Member

We could load all addons we know @storybook/addon-** and the community developed ones storybook-addon-** by reading the package.json.

@tmeasday
Copy link
Member

I think "automagic" like this hurts more than it helps. People don't really understand how it works and so when they have problems they don't have any clue how to fix them.

It doesn't seem worth it to save a one line import '@kadira/storybook-addon-notes/register'; (etc)

@usulpro
Copy link
Member

usulpro commented Apr 13, 2017

In general I like the idea of lowering the barrier to entry. Take a look at storybook-addon-material-ui. It's more Material-UI tool then Storybook, and people coming from there maybe never use Storybook before. So making their life easier is make sense for me.

On the other hand, in addition to registering the addon, we need some templates. That's why I'd like to have some API like $ getstorybook storybook-template-material-ui

@ndelangen
Copy link
Member Author

@usulpro Can you make a note about templates on this issue: #1108

@tmeasday Do you recommend we do not do this?

@tmeasday
Copy link
Member

That is my recommendation, yes. Not so wedded to it that I would complain if we wanted to go another way, but this is based on my experience with other OSS projects.

@shilman
Copy link
Member

shilman commented Jul 11, 2017

Definitely with @tmeasday on this one, and for the same reasons (cough, Meteor, cough)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants