Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native Storybook v5.1.0rc3 add-on tabs cannot be seen on simulator. #6917

Closed
lyqht opened this issue May 31, 2019 · 11 comments
Closed

Comments

@lyqht
Copy link

lyqht commented May 31, 2019

Describe the bug
After upgrading storybook-react-native to ver 5.1.3-rc, there is a lack of padding / margin around the app. Now I am not able to click on the add-on notes & knobs tabs.

Expected behavior
I should be able to click on the add-on tabs.

Screenshots
on ver 5.1.3-rc
image

on ver 4.1.18
image

System:

  • Device: iPhoneX simulator
  • Framework: React-Native
  • Addons: addon-ondevice notes & knobs
@lyqht lyqht changed the title React-Native Storybook v5.1.3rc add-on tabs cannot be seen on simulator. React-Native Storybook v5.1.0rc3 add-on tabs cannot be seen on simulator. May 31, 2019
@github-actions
Copy link
Contributor

Automention: Hey @benoitdion @Gongreg, you've been tagged! Can you give a hand here?

@lyqht
Copy link
Author

lyqht commented Jun 7, 2019

tested on "@storybook/react-native": "^5.1.3", same issue

@goldenlove
Copy link

5.1.9, same issue here~ 😆
a temporary solution:
use iPhone 8 Plus or other “none notch" device Instead of iPhoneX simulator~ lol

@Gongreg
Copy link
Member

Gongreg commented Jun 26, 2019

Hey. It seems that safe area view is missing as a wrapper for storybook. Would someone like to add it?

@stale
Copy link

stale bot commented Jul 17, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jul 17, 2019
@Gongreg Gongreg removed the inactive label Jul 17, 2019
@pvinis
Copy link
Contributor

pvinis commented Jul 25, 2019

Was this working on 4? If yes, I could do a bisect, but I don't know how big the changes were from 4 to 5.

@Gongreg
Copy link
Member

Gongreg commented Jul 25, 2019

Hey, I don’t think so. We need to addSafeAreaView wrapper. Could you add it?

@bqrichards
Copy link
Contributor

I can do this if you haven't started already @pvinis

@pvinis
Copy link
Contributor

pvinis commented Jul 25, 2019

feel free to take this :)

@stale
Copy link

stale bot commented Aug 15, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@shilman
Copy link
Member

shilman commented Aug 22, 2019

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.39 containing PR #7809 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@stale stale bot removed the inactive label Aug 22, 2019
@shilman shilman closed this as completed Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants