-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React-Native Storybook v5.1.0rc3 add-on tabs cannot be seen on simulator. #6917
Comments
Automention: Hey @benoitdion @Gongreg, you've been tagged! Can you give a hand here? |
tested on |
5.1.9, same issue here~ 😆 |
Hey. It seems that safe area view is missing as a wrapper for storybook. Would someone like to add it? |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Was this working on 4? If yes, I could do a bisect, but I don't know how big the changes were from 4 to 5. |
Hey, I don’t think so. We need to addSafeAreaView wrapper. Could you add it? |
I can do this if you haven't started already @pvinis |
feel free to take this :) |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.39 containing PR #7809 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Describe the bug
After upgrading storybook-react-native to ver 5.1.3-rc, there is a lack of padding / margin around the app. Now I am not able to click on the add-on notes & knobs tabs.
Expected behavior
I should be able to click on the add-on tabs.
Screenshots

on ver 5.1.3-rc
on ver 4.1.18

System:
The text was updated successfully, but these errors were encountered: