-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors logged by official-storybook
#3679
Comments
I'm getting the bug: It further says to check the following spots
So far, everything seems to be working despite the bug. |
"Warning: Stateless function components cannot be given refs. Attempts to access this ref will fail." is being fixed right now on the theming branch |
BTW, It happens on every app, because of the manager. |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Comment to keep this issue open. We just ran into it with |
It happens with using Angular at 4.0-alpha10 as well |
seeing this issue still trying to incorporate an emotion theme decorator: import React from 'react';
import { storiesOf } from '@storybook/react';
import { Button } from './Button';
import { ThemeProvider } from 'emotion-theming';
import { theme } from '../../constants/theme';
const Theme = storyFn => (
<ThemeProvider theme={theme}>{storyFn()}</ThemeProvider>
);
storiesOf('Components/Button', module)
.addDecorator(Theme)
.addWithJSX('primary', () => (
<Button>I am a Button</Button>
)); |
It's not happening anymore. |
thanks! |
@ndelangen I'm creating an issue recording what I find here.
"Warning: Stateless function components cannot be given refs. Attempts to access this ref will fail."
This is due to switching certain UI components from classes to SFCs. The actually use of the ref comes on this line of
react-komposer
:https://github.com/storybooks/react-komposer/blob/975fa67f07ca75f889ae2161b047b4d7037fa013/src/compose.js#L126-L128
I'm not sure if that
ref
is ever used (perhaps @Hypnosphi remembers something) but if I pass{ withRef: false }
as a second argument tocompose()
here and here the error goes away (and the UI still appears to work).Warning: Unsafe lifecycle methods were found within a strict-mode tree
This issue: emotion-js/emotion#644
Plus similar problems with
react-split-pane
(our issue andreact-modal
(reactjs/react-modal#649), et al (Velocity also)The text was updated successfully, but these errors were encountered: