Deprecation warnings after upgrade to TS 4.8 #19055

gerhat · 2022-08-30T09:31:23Z

Describe the bug
After upgrading TypeScript to 4.8.2 from 4.7.4 I am getting the following deprecation warnings at the console:

info @storybook/react v6.5.10
info 
info => Loading presets
info => Loading custom manager config
info Addon-docs: using MDX1
info => Using implicit CSS loaders
info => Loading custom manager config
info => Using default Webpack4 setup
12% building 20/23 modules 3 active ...w.js-generated-config-entry.js
info => Using cached manager
70% sealing React Docgen Typescript PluginDeprecationWarning: 'createIdentifier' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: '' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createLiteral' has been deprecated since v4.0.0. Use `factory.createStringLiteral`, `factory.createStringLiteralFromNode`, `factory.createNumericLiteral`, `factory.createBigIntLiteral`, `factory.createTrue`, `factory.createFalse`, or the factory supplied by your transformation context instead.
DeprecationWarning: 'createBinaryExpression' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createExpressionStatement' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createPropertyAssignment' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createObjectLiteralExpression' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createExpressionStatement' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createTypeOfExpression' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createElementAccessExpression' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createIfStatement' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createBlock' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createVariableDeclaration' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createCatchClause' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createTryStatement' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createNull' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createFalse' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createTrue' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.
DeprecationWarning: 'createArrayLiteralExpression' has been deprecated since v4.0.0. Use the appropriate method on 'ts.factory' or the 'factory' supplied by your transformation context instead.

To Reproduce
Execute:

$ npx sb@next repro

Then select:
react, react_typescript, any_folder_name e.g.:

✔ 🌈 Select the repro framework › react
✔ 📝 Select the repro base template › react_typescript
✔ Enter the output directory … TS4.8-deprecations

After it finishes installing everything try:

$ cd TS4.8-deprecations
$ yarn storybook

You should be able to see the warnings towards the top.

System

Environment Info:

  System:
    OS: macOS 12.5.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
  Binaries:
    Node: 14.20.0 - /usr/local/bin/node
    npm: 6.14.17 - /usr/local/bin/npm
  Browsers:
    Chrome: 104.0.5112.101
    Edge: 104.0.1293.70
    Firefox: 104.0
    Safari: 15.6.1
  npmPackages:
    @storybook/addon-actions: ^6.5.10 => 6.5.10 
    @storybook/addon-docs: ^6.5.10 => 6.5.10 
    @storybook/addon-essentials: ^6.5.10 => 6.5.10 
    @storybook/addon-knobs: ^6.4.0 => 6.4.0 
    @storybook/addon-links: ^6.5.10 => 6.5.10 
    @storybook/react: ^6.5.10 => 6.5.10

The text was updated successfully, but these errors were encountered:

lianapache · 2022-09-10T06:23:26Z

This seems to be an issue with react-docgen-typescript-plugin

LinnJS · 2022-09-22T12:31:07Z

Having the same issue happy to see this issue is known 😄

Moumouls · 2022-10-11T10:07:05Z

Hi @shilman

A PR was sent on the dep repo hipstersmoothie/react-docgen-typescript-plugin#70

Any chance to motivate @hipstersmoothie to merge, release and then update storybook/react dep to fix warnings ? 🚀

gravyboat · 2022-10-17T16:54:58Z

hipstersmoothie/react-docgen-typescript-plugin#70 has been merged. If anyone has time to bump this to see if it addresses the warnings that would be great!

ghost · 2022-11-05T16:46:54Z

I can't get rid of the warning. Can I try something?

Moumouls · 2022-11-08T10:39:01Z

@gravyboat @yogarasu @LinnJS @lianapache @gerhat after updating to latest version (6.5.13) warnings are gone.

Note: i'm using react 18

MirKml · 2022-11-08T17:33:19Z

Nope for me, warnings are still presented is sb 6.5.13. It seems that storybook uses own fork of mentioned plugin

@storybook/react-docgen-typescript-plugin@1.0.2-canary.6.9d540b91e815f8fc2f8829189deb00553559ff63.0 in my storybook installation.

It means that someone from storybook core maintainers has to update this dependency according mentioned issue by @gravyboat. Then it will be fixed.

MirKml · 2022-11-18T18:17:05Z

It seems that @shilman is responsible for plugin fork - https://github.com/storybookjs/react-docgen-typescript-plugin.
So @shilman please, can you update @storybook/react-docgen-typescript-plugin to upstream version which includes updates mentioned by @gravyboat which seems fixed this issue?

current stable Typescript is 4.9.2 (4.9 was released before 2 days), but many of us stuck with 4.7.x because of this issue.

felixhaeberle · 2022-11-23T11:42:56Z

Would be cool to see it this merged!! :)

matthew-dean · 2022-11-26T01:00:05Z

I'm getting this issue with TypeScript 4.9.3.

UPDATE: If you're using pnpm (and maybe Yarn?), you can manually fix this with a key like this in your package.json file:

  "pnpm": {
    "overrides": {
      "@storybook/react-docgen-typescript-plugin": "npm:react-docgen-typescript-plugin@1.0.2"
    }
  }

Note sure why Storybook forked it, or why they aren't keeping it up to date, but that removes the deprecation warnings. 🤷

MirKml · 2022-11-29T17:36:11Z

@matthew-dean according the repo, it seems that there are some storybook patches, so I don't know if overriding plugin is save. It's used in doc part of the storybook.
When you overrides, all your doc pages are fine?

@onigoetz made the PR storybookjs/react-docgen-typescript-plugin#8, thank you very much. So @shilman can you review, merge this one? For upcoming 6.5.14 which is in progress please.

HyejinYang · 2022-12-01T14:02:12Z

I also encountered this issue. It would be nice if it can be fixed in the upcoming 6.5.14 release as @MirKml said.

bosycom · 2022-12-14T21:59:43Z

Issue still present in storybook 6.5.14. Looking forward to a fix.

The following is a workaround that worked for me using yarn 3.x:

Add to package.json:

  "resolutions": {
    "@storybook/react-docgen-typescript-plugin": "npm:react-docgen-typescript-plugin@1.0.2"
  }

Run yarn
Fixed, storybook runs without deprecation warnings from the plugin

marksy · 2023-01-09T02:44:35Z

@bosycom's resolution workaround worked for me, for the time being.

alb3rtuk · 2023-01-10T15:56:05Z

@bosycom's solution worked for me! Many thanks :)

kaiyoma · 2023-01-10T19:56:09Z

Just upgraded to the latest Storybook (6.5.15) and still seeing this.

tsmithdk · 2023-01-12T10:26:00Z

Issue still present in storybook 6.5.14. Looking forward to a fix.

The following is a workaround that worked for me using yarn 3.x:

Add to package.json:
  "resolutions": {
    "@storybook/react-docgen-typescript-plugin": "npm:react-docgen-typescript-plugin@1.0.2"
  }
Run yarn

Fixed, storybook runs without deprecation warnings from the plugin

Tried the fix but didn't work for 6.5.15

DannyJoris · 2023-01-13T15:16:55Z

Same issue in 7.0.0-beta.20.

supunTE · 2023-01-31T04:58:31Z

Issue still present in storybook 6.5.14. Looking forward to a fix.

The following is a workaround that worked for me using yarn 3.x:

Add to package.json:
  "resolutions": {
    "@storybook/react-docgen-typescript-plugin": "npm:react-docgen-typescript-plugin@1.0.2"
  }
Run yarn

Fixed, storybook runs without deprecation warnings from the plugin

Same warnings with "@nrwl/storybook": "^15.6.2",
This didn't work.

uditalias · 2023-02-02T10:03:50Z

Same issue with 6.5.16
All the above solutions didn't work.
Also, storybook is not running with node v18. Only v16.

shilman · 2023-02-15T11:53:00Z

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.48 containing PR #21095 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

MirKml · 2023-02-15T20:12:56Z

I see you drop fork completely - 👍. Little bit sad that it's only for sb 7.0+, but it's OK, workaround with package.json overrides works. I will looking forward for 7.0 with typescript 5.0 😉

BTW @uditalias - latest sb 6 works fine with node 18

Jack-Works · 2023-02-24T12:19:19Z

still happens in 7.0.0 beta 53

shilman · 2023-03-03T16:48:34Z

Ermahgerd!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-beta.61 containing PR #21380 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb@next upgrade --prerelease

andrevenancio · 2023-03-17T13:34:10Z

Using latest typescript 5.0.2 causes issues with storybook-addon-actions, and if I revert to typescript 4.9.5 I get to this issue which is still NOT resolved :(

crunchwrap89 · 2023-03-24T15:43:15Z

If you add below code to your package.json it will remove the deprecation warnings, yes.
But it will make your hot reload 300% slower.
I guess deprecation warnings are better in this case.

"resolutions": {
"@storybook/react-docgen-typescript-plugin": "npm:react-docgen-typescript-plugin@1.0.2"
}

gerhat added bug needs triage labels Aug 30, 2022

gerhat changed the title ~~Deprecation warnings after update to TS 4.8~~ Deprecation warnings after upgrade to TS 4.8 Aug 30, 2022

PointSingularity mentioned this issue Sep 19, 2022

Update: Migrate to Tanstack React Query 4 and dts alan2207/react-query-auth#16

Closed

takurinton mentioned this issue Sep 28, 2022

Update Node.js version of CI runtime and storybook voyagegroup/ingred-ui#1007

Merged

gravyboat mentioned this issue Oct 17, 2022

Update typescript and fix deprecation warnings hipstersmoothie/react-docgen-typescript-plugin#70

Merged

onigoetz mentioned this issue Nov 22, 2022

[Bug]: update deprecations #19816

Closed

onigoetz mentioned this issue Nov 25, 2022

update typescript and fix deprecation warnings storybookjs/react-docgen-typescript-plugin#8

Merged

emrum01 mentioned this issue Dec 21, 2022

node18に対応させた yumemi-inc/yumeshop-frontend#127

Merged

shilman added this to Core Team Projects Feb 4, 2023

shilman moved this to Required for QA in Core Team Projects Feb 4, 2023

shilman added dependencies and removed needs triage labels Feb 4, 2023

shilman self-assigned this Feb 4, 2023

vanessayuenn moved this from Required for QA to In Progress in Core Team Projects Feb 7, 2023

This was referenced Feb 13, 2023

[Bug]: react-docgen-typescript-plugin: Deprecation warnings after updating to TypeScript 4.8 #19618

Closed

Upgrade react-docgen-typescript-plugin #21095

Merged

shilman closed this as completed in #21095 Feb 15, 2023

github-project-automation bot moved this from In Progress to Done in Core Team Projects Feb 15, 2023

shilman moved this from Done to In Progress in Core Team Projects Feb 21, 2023

shilman reopened this Feb 21, 2023

shilman mentioned this issue Feb 21, 2023

[Bug]: Crash with @storybook/react under ts 5.0.0-beta #20826

Closed

Jack-Works mentioned this issue Feb 22, 2023

chore: upgrade to typescript 5.0 DimensionDev/Maskbook#8571

Closed

13 tasks

shilman mentioned this issue Mar 3, 2023

Upgrade react-docgen-typescript-plugin for TS4.8 #21380

Merged

2 tasks

shilman closed this as completed in #21380 Mar 3, 2023

github-project-automation bot moved this from In Progress to Done in Core Team Projects Mar 3, 2023

baggy-1 mentioned this issue Mar 11, 2023

Storybook playground FILMDOM-s/film-doms#37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecation warnings after upgrade to TS 4.8 #19055

Deprecation warnings after upgrade to TS 4.8 #19055

gerhat commented Aug 30, 2022

lianapache commented Sep 10, 2022

LinnJS commented Sep 22, 2022

Moumouls commented Oct 11, 2022

gravyboat commented Oct 17, 2022

ghost commented Nov 5, 2022

Moumouls commented Nov 8, 2022

MirKml commented Nov 8, 2022

MirKml commented Nov 18, 2022

felixhaeberle commented Nov 23, 2022

matthew-dean commented Nov 26, 2022 •

edited

Loading

MirKml commented Nov 29, 2022 •

edited

Loading

HyejinYang commented Dec 1, 2022

bosycom commented Dec 14, 2022

marksy commented Jan 9, 2023

alb3rtuk commented Jan 10, 2023

kaiyoma commented Jan 10, 2023

tsmithdk commented Jan 12, 2023

DannyJoris commented Jan 13, 2023

supunTE commented Jan 31, 2023

uditalias commented Feb 2, 2023

shilman commented Feb 15, 2023

MirKml commented Feb 15, 2023

Jack-Works commented Feb 24, 2023

shilman commented Mar 3, 2023

andrevenancio commented Mar 17, 2023

crunchwrap89 commented Mar 24, 2023

Deprecation warnings after upgrade to TS 4.8 #19055

Deprecation warnings after upgrade to TS 4.8 #19055

Comments

gerhat commented Aug 30, 2022

lianapache commented Sep 10, 2022

LinnJS commented Sep 22, 2022

Moumouls commented Oct 11, 2022

gravyboat commented Oct 17, 2022

ghost commented Nov 5, 2022

Moumouls commented Nov 8, 2022

MirKml commented Nov 8, 2022

MirKml commented Nov 18, 2022

felixhaeberle commented Nov 23, 2022

matthew-dean commented Nov 26, 2022 • edited Loading

MirKml commented Nov 29, 2022 • edited Loading

HyejinYang commented Dec 1, 2022

bosycom commented Dec 14, 2022

marksy commented Jan 9, 2023

alb3rtuk commented Jan 10, 2023

kaiyoma commented Jan 10, 2023

tsmithdk commented Jan 12, 2023

DannyJoris commented Jan 13, 2023

supunTE commented Jan 31, 2023

uditalias commented Feb 2, 2023

shilman commented Feb 15, 2023

MirKml commented Feb 15, 2023

Jack-Works commented Feb 24, 2023

shilman commented Mar 3, 2023

andrevenancio commented Mar 17, 2023

crunchwrap89 commented Mar 24, 2023

matthew-dean commented Nov 26, 2022 •

edited

Loading

MirKml commented Nov 29, 2022 •

edited

Loading