Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Essentials: npm8 support for sb init #17319

Closed
shilman opened this issue Jan 24, 2022 · 1 comment
Closed

Essentials: npm8 support for sb init #17319

shilman opened this issue Jan 24, 2022 · 1 comment

Comments

@shilman
Copy link
Member

shilman commented Jan 24, 2022

@shilman Is there a proposed solution for NPM 8? I've pulled all storybook dependencies into a separate NPM project and listed @storybook/addon-docs as a dependencies:

    "@storybook/addon-actions": "^6.3.6",
    "@storybook/addon-docs": "^6.3.12",
    "@storybook/addon-essentials": "^6.3.6",
    "@storybook/addon-links": "^6.3.6",
    "@storybook/builder-webpack5": "^6.3.12",
    "@storybook/cli": "^6.3.6",
    "@storybook/components": "^6.3.0",
    "@storybook/core-events": "^6.3.0",
    "@storybook/manager-webpack5": "^6.3.12",
    "@storybook/react": "^6.3.6",
    "@storybook/theming": "^6.3.0",

However, NPM 8 installs this in the packages node_modules. i.e. <project_root>/node_modules/@my_package/node_modules/@storybook/addon-docs and Webpack can't find it.

On the other hand, if I install @storybook/addon-docs in my project root, it resolves and Webpack builds correctly.

Originally posted by @josh-biddick in #14429 (comment)

@shilman
Copy link
Member Author

shilman commented Jun 8, 2023

We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant